[U-Boot] [PATCH V2 3/3] Add support for the LaCie ED Mini V2 board

Albert ARIBAUD
2009-11-29T11:22:31Z

Prafulla Wadaskar a ?crit :

>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index d70a9d2..93e57f5 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -512,6 +512,10 @@ Unknown / orphaned boards:
>> # Board CPU
>> #
>>
>> ##############################################################
>> ###########
>>
>> +Albert ARIBAUD <albert.aribaud@free.fr>
>> +
>> + edminiv2 ARM926EJS (Orion5x SoC)
>> +
>
> That's good if you can move this entry above Albin Tonnerre's entry

Are you sure? Seems to me like this list is ordered by last, not first,
name.

> How you are addressing DRAM configuration?
> I think you need lowlevel_init.

Yes. That will be in patch V3.

> ...snip...
>> +/*
>> + * Environment variables configurations
>> + */
>> +#define CONFIG_ENV_IS_IN_FLASH 1
>> +#define CONFIG_ENV_SECT_SIZE 0x2000 /* 16K */
>> +#define CONFIG_ENV_SIZE 0x2000
>> +#define CONFIG_ENV_OFFSET 0x4000 /* env starts here */
>
> I don't know how this is going to work, how much flash do you have?

51KB NOR located at fff88000 in the final mapping, and mirrored
throughout f8000000-ffffffff at power-up. That's an MX29LV400CB, with a
1x16kb,2x8kb,1x32kb,7x64kb region layout, of which U-boot utilizes the 7
64K banks for code and the lowest 8K bank for environment.

> I hope it is mapped in the end since your reset address is 0xffff0000.

This *does* work, I step-debugged through the Orion init sequence. The
fact is, there's ROM code in the Orion SoC apparently, at 0xffff0000,
and which takes precedence over the boot CS. This ROM code checks the
SoC device type and, if 5182, branches to 0xfff90000 (at this point a
mirror of the boot CS).

> Where is the code to fetch flashed image from flash to DRAM at TEXT_BASE?

That's done by the start.S relocation code, subject to not defining
CONFIG_SKIP_RELOCATION of course. Note that Orion has NOR flash, not NAND.

> I suggest you provide some more details about your board in the commit log

I will.

Amicalement,
--
Albert.