[U-Boot] [PATCH V2 3/3] Add support for the LaCie ED Mini V2 board

Wolfgang Denk
2009-12-05T00:35:07Z

Dear Albert ARIBAUD,

In message <4B126F68.9020005@free.fr> you wrote:
>
> > Cannot you use get_ram_size() for auto-sizing and checking?
>
> The SoC allows for up to 4 banks of DRAM, not necessarily contiguous.
> Granted, this is not a frequent configuration, however I'd like to
> support it correctly, and the heuristics of get_ram_size() are based on
> the assumption that all DRAM is contiguous.

No, this is not correct. get_ram_size() is used always on a single
bank of memory only.

> However I realize that this code is actually SoC-specific, not
> board-specific. It could be moved in cpu/arm926ejs/orion5x/dram.c, and
> then orion5x_sdram_{bar,bs} could be made static (or inlined).
>
> What do you think?

Seems to make sense.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A memorandum is written not to inform the reader, but to protect the
writer. -- Dean Acheson