[U-Boot] [PATCH V2 3/3] Add support for the LaCie ED Mini V2 board

Albert ARIBAUD
2009-12-05T07:03:05Z

Wolfgang Denk a ?crit :
> Dear Albert ARIBAUD,
>
> In message <4B126F68.9020005@free.fr> you wrote:
>>> Cannot you use get_ram_size() for auto-sizing and checking?
>> The SoC allows for up to 4 banks of DRAM, not necessarily contiguous.
>> Granted, this is not a frequent configuration, however I'd like to
>> support it correctly, and the heuristics of get_ram_size() are based on
>> the assumption that all DRAM is contiguous.
>
> No, this is not correct. get_ram_size() is used always on a single
> bank of memory only.

Do you mean calling get_ram_size() four up to times based on the
configured number of banks and configured sizes? I then fail to see the
added value of get_ram_size() wrt using the configured sizes directly.

>> However I realize that this code is actually SoC-specific, not
>> board-specific. It could be moved in cpu/arm926ejs/orion5x/dram.c, and
>> then orion5x_sdram_{bar,bs} could be made static (or inlined).
>>
>> What do you think?
>
> Seems to make sense.

All right. Does doing that lift the requirement to use get_ram_size()?

> Best regards,
>
> Wolfgang Denk

Amicalement,
--
Albert.