[U-Boot] [PATCH V2 1/3] Initial support for Marvell Orion5x SoC

Albert ARIBAUD
2009-11-29T10:34:07Z

Wolfgang Denk a ?crit :
> Dear Albert Aribaud,

>> diff --git a/include/asm-arm/arch-orion5x/88f5182.h b/include/asm-arm/arch-orion5x/88f5182.h
>> new file mode 100644
>> index 0000000..b16b23f
>> --- /dev/null
>> +++ b/include/asm-arm/arch-orion5x/88f5182.h
>
> 88f5182 is a terrible file name. Can you not come up with something
> more descriptive, please?

(Pre)fixed: file is now mv88f5182.h. That's the best I can do since
88F5182 is actually the SoC variant 'name'. Expect 'mv88f5181.h',
'mv88f5281.h' in the future.

>> diff --git a/include/asm-arm/arch-orion5x/gpio.h b/include/asm-arm/arch-orion5x/gpio.h
>> new file mode 100644
>> index 0000000..58592ad
>> --- /dev/null
>> +++ b/include/asm-arm/arch-orion5x/gpio.h
> ...
>> +/*
>> + * Orion5x-specific GPIO API
>> + */
>
> Why do we need an Orion5x-specific GPIO API? Can't we use something
> that is more general?

I've looked at the current u-boot code and have found no generic GPIO
API -- and six different, specific ones. Is there an effort going on to
generalize this?

Amicalement,
--
Albert.