public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix debug output.
Date: Mon, 07 Dec 2009 13:07:54 +0100	[thread overview]
Message-ID: <20091207120754.AE6EA3F6CC@gemini.denx.de> (raw)
In-Reply-To: <1260177679-18337-1-git-send-email-weber@corscience.de>

Dear Thomas Weber,

In message <1260177679-18337-1-git-send-email-weber@corscience.de> you wrote:
> Signed-off-by: Thomas Weber <weber@corscience.de>
> ---
>  drivers/net/dm9000x.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/dm9000x.c b/drivers/net/dm9000x.c
> index 73dd335..08bd794 100644
> --- a/drivers/net/dm9000x.c
> +++ b/drivers/net/dm9000x.c
> @@ -74,8 +74,8 @@ TODO: external MII is not functional, only internal at the moment.
>  #define DM9000_DBG(fmt,args...) printf(fmt, ##args)
>  #define DM9000_DMP_PACKET(func,packet,length)  \
>  	do { \
> -		int i; 							\
> -		printf(func ": length: %d\n", length);			\
> +     	int i; 							\
> +		printf("%s: length: %d\n",func, length);			\
>  		for (i = 0; i < length; i++) {				\
>  			if (i % 8 == 0)					\
>  				printf("\n%s: %02x: ", func, i);	\

Which problem is this supposed to fix? 

Actually this patch introduces two new issues (the "int i;" line uses
spaces for indentation, and the '\' are not vertically aligned any
more).

NAK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A girl with a future avoids the man with a past.
                                   -- Evan Esar, "The Humor of Humor"

  parent reply	other threads:[~2009-12-07 12:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-07  9:21 [U-Boot] [PATCH] Fix debug output Thomas Weber
2009-12-07 10:43 ` Mike Frysinger
2009-12-07 11:27   ` Thomas Weber
2009-12-07 12:08     ` Wolfgang Denk
2009-12-07 12:07 ` Wolfgang Denk [this message]
2009-12-07 13:11   ` Thomas Weber
2009-12-07 20:09     ` Wolfgang Denk
2009-12-08 20:38       ` Thomas Weber
2009-12-08 20:43         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091207120754.AE6EA3F6CC@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox