public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix computation in nand_util.c:get_len_incl_bad
Date: Mon, 07 Dec 2009 22:38:33 +0100	[thread overview]
Message-ID: <20091207213833.B0E173F6CC@gemini.denx.de> (raw)
In-Reply-To: <1259672755-929-1-git-send-email-daniel.hobi@schmid-telecom.ch>

Dear Daniel Hobi,

In message <1259672755-929-1-git-send-email-daniel.hobi@schmid-telecom.ch> you wrote:
> Depending on offset, flash size and the number of bad blocks,
> get_len_incl_bad may return a too small value which may lead to:
> 
> 1) If there are no bad blocks, nand_{read,write}_skip_bad chooses the
> bad block aware read/write code. This may hurt performance, but does
> not have any adverse effects.
> 
> 2) If there are bad blocks, the nand_{read,write}_skip_bad may choose
> the bad block unaware read/write code (if len_incl_bad == *length)
> which leads to corrupted data.
> 
> Signed-off-by: Daniel Hobi <daniel.hobi@schmid-telecom.ch>
> ---
> @Scott: please review
> @Wolfgang: please consider for 2009.11
> 
> diff --git a/drivers/mtd/nand/nand_util.c b/drivers/mtd/nand/nand_util.c

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Intelligence without character is a dangerous thing."   - G. Steinem

      parent reply	other threads:[~2009-12-07 21:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-01 13:05 [U-Boot] [PATCH] Fix computation in nand_util.c:get_len_incl_bad Daniel Hobi
2009-12-01 23:55 ` Scott Wood
2009-12-05  0:44   ` Wolfgang Denk
2009-12-07 21:38 ` Wolfgang Denk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091207213833.B0E173F6CC@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox