From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 15 Dec 2009 13:24:54 +0100 Subject: [U-Boot] [PATCH ARM 3/3] s3c24x0 code style changes In-Reply-To: <4B2548FF.6040103@fearnside-systems.co.uk> References: <4B2548FF.6040103@fearnside-systems.co.uk> Message-ID: <20091215122454.70D54C88AF@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear "kevin.morfitt at fearnside-systems.co.uk", In message <4B2548FF.6040103@fearnside-systems.co.uk> you wrote: > Cleans up the s3c24x0 header files by changing the upper case members > of the s3c24x0 register structures to lower case and changing all code > that uses these register structures. The commit message should also mention that you convert the code into using accessor functions. You also perform a white space cleanup here. this may be a good thing (opinions differ), but in any case it is an unrelated change that must be performed in a separate commit. Note that the same applies to the other two patches. Please also re-check the resulting code. I think there are some way too long lines, etc. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de > Is there a way to determine Yesterday's date using Unix utilities? echo "what is yesterday's date?" | /bin/mail root -- Randal L. Schwartz in