From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision
Date: Wed, 16 Dec 2009 23:15:20 +0100 [thread overview]
Message-ID: <20091216221520.72F564C026@gemini.denx.de> (raw)
In-Reply-To: <B85A65D85D7EB246BE421B3FB0FBB59301E157AAE8@dbde02.ent.ti.com>
Dear "Premi, Sanjeev",
In message <B85A65D85D7EB246BE421B3FB0FBB59301E157AAE8@dbde02.ent.ti.com> you wrote:
>
> Also, I don't believe there is any complexity added as
> the contents of register are being read and saved in a
> global variable for use later.
Global variables are a bad thing if there is not really a good reason
to hav ethem. Here it makes no sense to me. Execution time seems
uncritical, and there is no kind of hardware wear involved with
readin the registers, so like Tom I don't see a reason for this
"optimization".
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How does a project get to be a year late? ... One day at a time.
next prev parent reply other threads:[~2009-12-16 22:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 13:18 [U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision Sanjeev Premi
2009-12-15 13:18 ` [U-Boot] [PATCH 1/2] omap3: Identify the CPU in arch_cpu_init() Sanjeev Premi
2009-12-15 13:18 ` [U-Boot] [PATCH 2/2] omap3: Identify cpu in s_init() Sanjeev Premi
2009-12-15 17:14 ` [U-Boot] [PATCH 0/2] omap3: Optimize detection of cpu revision Tom
2009-12-15 18:44 ` Premi, Sanjeev
2009-12-16 22:15 ` Wolfgang Denk [this message]
2010-01-07 14:56 ` Premi, Sanjeev
2010-01-07 15:32 ` Paulraj, Sandeep
2010-01-08 10:41 ` Premi, Sanjeev
2010-01-11 17:15 ` Premi, Sanjeev
2010-01-12 13:44 ` Tom
2010-01-17 21:32 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091216221520.72F564C026@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox