public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 07/25] Blackfin: do not require CONFIG_BAUDRATE
Date: Thu, 17 Dec 2009 17:34:33 -0500	[thread overview]
Message-ID: <200912171734.34098.vapier@gentoo.org> (raw)
In-Reply-To: <20091217213238.98511D43F21@gemini.denx.de>

On Thursday 17 December 2009 16:32:38 Wolfgang Denk wrote:
> Mike Frysinger wrote:
> > Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> > ---
> >  cpu/blackfin/initcode.c |    3 +++
> >  lib_blackfin/board.c    |    2 ++
> >  2 files changed, 5 insertions(+), 0 deletions(-)
> 
> ...
> 
> >  static int init_baudrate(void)
> >  {
> > +#ifdef CONFIG_BAUDRATE
> >  	char baudrate[15];
> >  	int i = getenv_r("baudrate", baudrate, sizeof(baudrate));
> >  	gd->bd->bi_baudrate = gd->baudrate = (i > 0)
> >  	    ? simple_strtoul(baudrate, NULL, 10)
> >
> >  	    : CONFIG_BAUDRATE;
> >
> > +#endif
> >  	return 0;
> >  }
> 
> Out of curiosity: what do these boards do when CONFIG_BAUDRATE is not
> defined?

the boards lack serial and/or dont use it.  they're controlled via JTAG.

> It seems yo me you add a new, additional meaning to the
> CONFIG_BAUDRATE option here. This should be documented (at least in
> the README).

i could just fall back to a value of 0 ... there'd be a little more useless 
code added, but not much to be done here seeing as how the rest of u-boot 
assumes baudrate is usable.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20091217/589d84bc/attachment.pgp 

  reply	other threads:[~2009-12-17 22:34 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-17  2:43 [U-Boot] [PATCH 00/25] Blackfin updates for v2010.03-rc0 Mike Frysinger
2009-12-17  2:43 ` [U-Boot] [PATCH 01/25] Blackfin: tweak embedded LDR env config option Mike Frysinger
2009-12-17  2:43 ` [U-Boot] [PATCH 02/25] Blackfin: update tiny board settings (voltage/default env) Mike Frysinger
2009-12-17  2:43 ` [U-Boot] [PATCH 03/25] Blackfin: bf537-stamp: rename SPI/MMC define Mike Frysinger
2009-12-17  2:43 ` [U-Boot] [PATCH 04/25] Blackfin: ADI settings: enable silent console support Mike Frysinger
2009-12-17  2:43 ` [U-Boot] [PATCH 05/25] Blackfin: bf561-acvilon: new board port Mike Frysinger
2009-12-17  2:43 ` [U-Boot] [PATCH 06/25] Blackfin: move section length calculation to linker script Mike Frysinger
2009-12-17  2:43 ` [U-Boot] [PATCH 07/25] Blackfin: do not require CONFIG_BAUDRATE Mike Frysinger
2009-12-17 21:32   ` Wolfgang Denk
2009-12-17 22:34     ` Mike Frysinger [this message]
2009-12-17  2:43 ` [U-Boot] [PATCH 08/25] Blackfin: kill off useless initdram() usage Mike Frysinger
2009-12-17 21:33   ` Wolfgang Denk
2009-12-17 22:23     ` Mike Frysinger
2009-12-17 22:48       ` Wolfgang Denk
2009-12-17 22:55         ` Mike Frysinger
2009-12-17  2:43 ` [U-Boot] [PATCH 09/25] Blackfin: global_data.h: make pull in needed headers Mike Frysinger
2009-12-17  2:43 ` [U-Boot] [PATCH 10/25] Blackfin: re-architecture initcode Mike Frysinger
2009-12-17  2:43 ` [U-Boot] [PATCH 11/25] Blackfin: support boards with no external memory Mike Frysinger
2009-12-17 21:36   ` Wolfgang Denk
2009-12-17  2:43 ` [U-Boot] [PATCH 12/25] Blackfin: bf527-ezkit: auto-select NAND settings Mike Frysinger
2009-12-17  2:43 ` [U-Boot] [PATCH 13/25] Blackfin: fix L1 Instruction sizes on BF52x/BF54x Mike Frysinger
2009-12-17  2:43 ` [U-Boot] [PATCH 14/25] Blackfin: move watchdog config check to Makefile Mike Frysinger
2009-12-17  2:44 ` [U-Boot] [PATCH 15/25] Blackfin: use new bfin read/write mmr helper funcs Mike Frysinger
2009-12-17 21:39   ` Wolfgang Denk
2009-12-17  2:44 ` [U-Boot] [PATCH 16/25] Blackfin: asm/string.h: drop useless includes Mike Frysinger
2009-12-17  2:44 ` [U-Boot] [PATCH 17/25] Blackfin: bfin_spi: let boards control idle value Mike Frysinger
2009-12-17  2:44 ` [U-Boot] [PATCH 18/25] Blackfin: convert bfin_sdh to generic mmc Mike Frysinger
2009-12-17  2:44 ` [U-Boot] [PATCH 19/25] Blackfin: bf533-stamp: split and cleanup CF/IDE code Mike Frysinger
2009-12-17  2:44 ` [U-Boot] [PATCH 20/25] Blackfin: drop unused funcs from io.h Mike Frysinger
2009-12-17  2:44 ` [U-Boot] [PATCH 21/25] Blackfin: section off the CF/IDE io.h hacks Mike Frysinger
2009-12-17 21:41   ` Wolfgang Denk
2009-12-17  2:44 ` [U-Boot] [PATCH 22/25] Blackfin: pull io funcs from linux Mike Frysinger
2009-12-17 21:43   ` Wolfgang Denk
2009-12-17 22:26     ` Mike Frysinger
2009-12-17 23:29     ` [U-Boot] MPC8313 with 512MB SDRAM, u-boot version 1.3.0 David Tao
2009-12-17  2:44 ` [U-Boot] [PATCH 23/25] Blackfin: bfin_spi: round up clock divider Mike Frysinger
2009-12-17  2:44 ` [U-Boot] [PATCH 24/25] Blackfin: bf527-ezkit/bf548-ezkit: add musb board specific initialization Mike Frysinger
2009-12-17  2:44 ` [U-Boot] [PATCH 25/25] Blackfin: add support for BF527-EZKIT v2.1 Mike Frysinger
2009-12-17 21:47   ` Wolfgang Denk
2009-12-17 22:27     ` Mike Frysinger
2009-12-22  0:55 ` [U-Boot] [PATCH 1/3] Blackfin: add a netconsole helper Mike Frysinger
2009-12-22  0:55 ` [U-Boot] [PATCH 2/3] Blackfin: keep hwtrace on CPLB miss Mike Frysinger
2009-12-22  0:55 ` [U-Boot] [PATCH 3/3] Blackfin: handle anomaly 05000257 Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200912171734.34098.vapier@gentoo.org \
    --to=vapier@gentoo.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox