From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing <asm/unaligned.h>
Date: Sat, 19 Dec 2009 01:04:36 +0100 [thread overview]
Message-ID: <20091219000436.AF2324C026@gemini.denx.de> (raw)
In-Reply-To: <4B2B79A9.1000106@symmetricore.com>
Dear Himanshu Chauhan,
In message <4B2B79A9.1000106@symmetricore.com> you wrote:
> Stefan Roese wrote:
> > On Friday 18 December 2009 13:20:56 Stefan Roese wrote:
> >>> I think thats what it is. Both are same.
> >> No, not exactly. They're nearly identical. But there are differences. Not
> >> sure if these differences are important though.
> >>
> >> Don't get me wrong. I'm not NACK'ing the patch. I'm just pointing out that
> >> it's different from the Linux version.
> >
> > Just to make it clear. Here a diff between both versions:
> >
> > --- u-boot/include/asm-mips/unaligned.h
> > +++ linux-2.6/linus/arch/mips/include/asm/unaligned.h
> > @@ -8,19 +8,21 @@
> > #ifndef _ASM_MIPS_UNALIGNED_H
> > #define _ASM_MIPS_UNALIGNED_H
> >
> > -#include <compiler.h>
> > +#include <linux/compiler.h>
> > #if defined(__MIPSEB__)
> > +# include <linux/unaligned/be_struct.h>
> > +# include <linux/unaligned/le_byteshift.h>
> > # define get_unaligned __get_unaligned_be
> > # define put_unaligned __put_unaligned_be
> > #elif defined(__MIPSEL__)
> > +# include <linux/unaligned/le_struct.h>
> > +# include <linux/unaligned/be_byteshift.h>
> > # define get_unaligned __get_unaligned_le
> > # define put_unaligned __put_unaligned_le
> > #else
> > # error "MIPS, but neither __MIPSEB__, nor __MIPSEL__???"
> > #endif
> >
> > -# include <linux/unaligned/le_byteshift.h>
> > -# include <linux/unaligned/be_byteshift.h>
> > # include <linux/unaligned/generic.h>
> >
> > #endif /* _ASM_MIPS_UNALIGNED_H */
> >
>
> I think whatever Shinya sent was modified version of linux's unaligned.h
> and its working.
Hm... has this really been tested on both big endian and on little
endian MIPS systems?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Beware of bugs in the above code; I have only proved it correct, not
tried it." - Donald Knuth
next prev parent reply other threads:[~2009-12-19 0:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-18 6:58 [U-Boot] Build breakage in qemu-mips Himanshu Chauhan
2009-12-18 10:32 ` [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing <asm/unaligned.h> Shinya Kuribayashi
2009-12-18 11:50 ` Himanshu Chauhan
2009-12-18 12:01 ` Stefan Roese
2009-12-18 12:04 ` Himanshu Chauhan
2009-12-18 12:20 ` Stefan Roese
2009-12-18 12:27 ` Stefan Roese
2009-12-18 12:46 ` Himanshu Chauhan
2009-12-19 0:04 ` Wolfgang Denk [this message]
2009-12-19 6:56 ` Himanshu Chauhan
2009-12-19 12:52 ` [U-Boot] [OT] List for sending patches Himanshu Chauhan
2009-12-19 13:54 ` Mike Frysinger
2009-12-19 19:04 ` Wolfgang Denk
2009-12-18 13:02 ` [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing <asm/unaligned.h> Shinya Kuribayashi
2009-12-18 13:06 ` Stefan Roese
2009-12-20 3:59 ` Shinya Kuribayashi
2009-12-18 13:03 ` [U-Boot] [PATCH]: U-Boot build failure with CONFIG_SYS_NO_FLASH defined for qemu-mips Himanshu Chauhan
2009-12-18 13:09 ` [U-Boot] [PATCH] MIPS: qemu_mips: Fix a build failure caused by missing <asm/unaligned.h> Himanshu Chauhan
2009-12-18 13:18 ` Shinya Kuribayashi
2009-12-19 6:57 ` [U-Boot] [PATCH][RESEND]: Fix for U-Boot build failure with CONFIG_SYS_NO_FLASH defined for qemu-mips Himanshu Chauhan
2009-12-20 3:53 ` Shinya Kuribayashi
2009-12-20 6:43 ` Himanshu Chauhan
2009-12-21 4:40 ` Shinya Kuribayashi
2010-03-20 22:58 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091219000436.AF2324C026@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox