[U-Boot] [PATCH] ppc: Don't use getenv_IPaddr() systems without network support

[U-Boot] [PATCH] ppc: Don't use getenv_IPaddr() systems without network support

[Stefan Roese]

This patch disables the usage of getenv_IPaddr() in lib_ppc/board.c
on systems that don't have network support enabled.

This fixes the following compilation problem:

./MAKEALL DP405
Configuring for DP405 board...
lib_ppc/libppc.a(board.o): In function `board_init_r':
/home/stefan/git/u-boot/u-boot/lib_ppc/board.c:858: undefined reference to `getenv_IPaddr'

Signed-off-by: Stefan Roese <sr@denx.de>
---
 lib_ppc/board.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/lib_ppc/board.c b/lib_ppc/board.c
index dd22f99..c1fbaa5 100644
--- a/lib_ppc/board.c
+++ b/lib_ppc/board.c
@@ -852,10 +852,10 @@ void board_init_r (gd_t *id, ulong dest_addr)
 #ifdef CONFIG_HAS_ETH5
 	eth_getenv_enetaddr("eth5addr", bd->bi_enet5addr);
 #endif
-#endif /* CONFIG_CMD_NET */
 
 	/* IP Address */
 	bd->bi_ip_addr = getenv_IPaddr ("ipaddr");
+#endif /* CONFIG_CMD_NET */
 
 	WATCHDOG_RESET ();
 
-- 
1.6.6.rc4

[U-Boot] [PATCH] ppc: Don't use getenv_IPaddr() systems without network support

[Matthias Fuchs]

Hi Stefan,

thanks for fixing this issue.

Acked-by: Matthias Fuchs <matthias.fuchs@esd.eu>

On Tuesday 22 December 2009 13:04, Stefan Roese wrote:
> This patch disables the usage of getenv_IPaddr() in lib_ppc/board.c
> on systems that don't have network support enabled.
> 
> This fixes the following compilation problem:
> 
> ./MAKEALL DP405
> Configuring for DP405 board...
> lib_ppc/libppc.a(board.o): In function `board_init_r':
> /home/stefan/git/u-boot/u-boot/lib_ppc/board.c:858: undefined reference to `getenv_IPaddr'
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  lib_ppc/board.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/lib_ppc/board.c b/lib_ppc/board.c
> index dd22f99..c1fbaa5 100644
> --- a/lib_ppc/board.c
> +++ b/lib_ppc/board.c
> @@ -852,10 +852,10 @@ void board_init_r (gd_t *id, ulong dest_addr)
>  #ifdef CONFIG_HAS_ETH5
>  	eth_getenv_enetaddr("eth5addr", bd->bi_enet5addr);
>  #endif
> -#endif /* CONFIG_CMD_NET */
>  
>  	/* IP Address */
>  	bd->bi_ip_addr = getenv_IPaddr ("ipaddr");
> +#endif /* CONFIG_CMD_NET */
>  
>  	WATCHDOG_RESET ();
>  

[U-Boot] [PATCH] ppc: Don't use getenv_IPaddr() systems without network support

[Wolfgang Denk]

Dear Stefan Roese,

In message <1261483470-29255-1-git-send-email-sr@denx.de> you wrote:
> This patch disables the usage of getenv_IPaddr() in lib_ppc/board.c
> on systems that don't have network support enabled.
> 
> This fixes the following compilation problem:
> 
> ./MAKEALL DP405
> Configuring for DP405 board...
> lib_ppc/libppc.a(board.o): In function `board_init_r':
> /home/stefan/git/u-boot/u-boot/lib_ppc/board.c:858: undefined reference to `getenv_IPaddr'
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  lib_ppc/board.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

Will this patch make the "bdinfo" command print a random IP address?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You see things; and you say ``Why?'' But I dream  things  that  never
were; and I say ``Why not?''
       - George Bernard Shaw _Back to Methuselah_ (1921) pt. 1, act 1

[U-Boot] [PATCH] ppc: Don't use getenv_IPaddr() systems without network support

[Stefan Roese]

Hi Wolfgang,

On Tuesday 22 December 2009 23:02:54 Wolfgang Denk wrote:
> > This patch disables the usage of getenv_IPaddr() in lib_ppc/board.c
> > on systems that don't have network support enabled.
> >
> > This fixes the following compilation problem:
> >
> > ./MAKEALL DP405
> > Configuring for DP405 board...
> > lib_ppc/libppc.a(board.o): In function `board_init_r':
> > /home/stefan/git/u-boot/u-boot/lib_ppc/board.c:858: undefined reference
> > to `getenv_IPaddr'
> >
> > Signed-off-by: Stefan Roese <sr@denx.de>
> > ---
> >  lib_ppc/board.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Will this patch make the "bdinfo" command print a random IP address?

Maybe. Or it will be all zero's. 

The first intention of this patch was to fix the recent build breakage on 
those boards without networking support. I'll try to cook up a patch to remove 
networking stuff from the bdinfo command soon.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de