From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/9] nand driver support for SPEAr SoCs
Date: Mon, 4 Jan 2010 17:06:23 -0600 [thread overview]
Message-ID: <20100104230622.GA24836@loki.buserror.net> (raw)
In-Reply-To: <1260955110-5656-4-git-send-email-vipin.kumar@st.com>
On Wed, Dec 16, 2009 at 02:48:24PM +0530, Vipin KUMAR wrote:
>
> Signed-off-by: Vipin <vipin.kumar@st.com>
Acked-by: Scott Wood <scottwood@freescale.com>
Some of the whitespace is a bit inconsistent, though:
> +int spear_nand_init(struct nand_chip *nand)
> +{
> + writel(FSMC_DEVWID_8 | FSMC_DEVTYPE_NAND | FSMC_ENABLE | FSMC_WAITON,
> + &fsmc_regs_p->genmemctrl_pc);
> + writel(readl(&fsmc_regs_p->genmemctrl_pc) | FSMC_TCLR_1 | FSMC_TAR_1,
> + &fsmc_regs_p->genmemctrl_pc);
Here you continue with two tabs...
> + writel(FSMC_THIZ_1 | FSMC_THOLD_4 | FSMC_TWAIT_6 | FSMC_TSET_0,
> + &fsmc_regs_p->genmemctrl_comm);
> + writel(FSMC_THIZ_1 | FSMC_THOLD_4 | FSMC_TWAIT_6 | FSMC_TSET_0,
> + &fsmc_regs_p->genmemctrl_attrib);
...and here with one tab plus 7 spaces.
> + nand->ecc.layout = &spear_nand_ecclayout;
There's an extra space before '=' here.
-Scott
next prev parent reply other threads:[~2010-01-04 23:06 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-16 9:18 [U-Boot] [PATCH 0/9] Support for SPEAr SoCs Vipin KUMAR
2009-12-16 9:18 ` [U-Boot] [PATCH 1/9] i2c driver support " Vipin KUMAR
2009-12-16 9:18 ` [U-Boot] [PATCH 2/9] smi " Vipin KUMAR
2009-12-16 9:18 ` [U-Boot] [PATCH 3/9] nand " Vipin KUMAR
2009-12-16 9:18 ` [U-Boot] [PATCH 4/9] usbd driver and usb boot firmware " Vipin KUMAR
2009-12-16 9:18 ` [U-Boot] [PATCH 5/9] SPEAr600 SoC support added Vipin KUMAR
2009-12-16 9:18 ` [U-Boot] [PATCH 6/9] SPEAr300 " Vipin KUMAR
2009-12-16 9:18 ` [U-Boot] [PATCH 7/9] SPEAr310 " Vipin KUMAR
2009-12-16 9:18 ` [U-Boot] [PATCH 8/9] SPEAr320 " Vipin KUMAR
2009-12-16 9:18 ` [U-Boot] [PATCH 9/9] SPEAr600 build " Vipin KUMAR
2009-12-17 20:14 ` Wolfgang Denk
2009-12-19 7:26 ` Vipin Kumar
2009-12-17 20:14 ` [U-Boot] [PATCH 8/9] SPEAr320 SoC " Wolfgang Denk
2009-12-19 7:21 ` Vipin Kumar
2009-12-17 20:13 ` [U-Boot] [PATCH 7/9] SPEAr310 " Wolfgang Denk
2009-12-19 7:19 ` Vipin Kumar
2009-12-17 20:09 ` [U-Boot] [PATCH 6/9] SPEAr300 " Wolfgang Denk
2009-12-19 7:10 ` Vipin Kumar
2009-12-19 7:25 ` Wolfgang Denk
2009-12-19 7:58 ` Vipin Kumar
2009-12-16 17:30 ` [U-Boot] [PATCH 5/9] SPEAr600 " Peter Tyser
2009-12-16 18:00 ` Armando VISCONTI
2009-12-16 18:28 ` Peter Tyser
2009-12-17 22:44 ` Wolfgang Denk
2009-12-17 22:54 ` Peter Tyser
2009-12-17 23:13 ` Wolfgang Denk
2009-12-19 7:31 ` Vipin Kumar
2009-12-16 23:09 ` Wolfgang Denk
2009-12-19 8:56 ` Vipin Kumar
2009-12-16 22:56 ` [U-Boot] [PATCH 4/9] usbd driver and usb boot firmware support for SPEAr SoCs Wolfgang Denk
2009-12-19 7:02 ` Vipin Kumar
2009-12-19 7:24 ` Wolfgang Denk
2009-12-19 8:46 ` Vipin Kumar
2010-01-04 23:06 ` Scott Wood [this message]
2010-01-05 3:53 ` [U-Boot] [PATCH 3/9] nand driver " Vipin KUMAR
2009-12-16 22:44 ` [U-Boot] [PATCH 2/9] smi " Wolfgang Denk
2009-12-19 6:44 ` Vipin Kumar
2009-12-19 7:20 ` Wolfgang Denk
2009-12-19 7:56 ` Vipin Kumar
2009-12-19 7:59 ` Albert ARIBAUD
2009-12-19 8:28 ` Vipin Kumar
2009-12-19 21:37 ` Wolfgang Denk
2009-12-16 22:31 ` [U-Boot] [PATCH 1/9] i2c " Wolfgang Denk
2009-12-16 16:49 ` [U-Boot] [PATCH 0/9] Support " Armando VISCONTI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100104230622.GA24836@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox