From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Mon, 4 Jan 2010 17:06:23 -0600
Subject: [U-Boot] [PATCH 3/9] nand driver support for SPEAr SoCs
In-Reply-To: <1260955110-5656-4-git-send-email-vipin.kumar@st.com>
References: <1260955110-5656-1-git-send-email-vipin.kumar@st.com>
	<1260955110-5656-2-git-send-email-vipin.kumar@st.com>
	<1260955110-5656-3-git-send-email-vipin.kumar@st.com>
	<1260955110-5656-4-git-send-email-vipin.kumar@st.com>
Message-ID: <20100104230622.GA24836@loki.buserror.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Wed, Dec 16, 2009 at 02:48:24PM +0530, Vipin KUMAR wrote:
> 
> Signed-off-by: Vipin <vipin.kumar@st.com>

Acked-by: Scott Wood <scottwood@freescale.com>

Some of the whitespace is a bit inconsistent, though:

> +int spear_nand_init(struct nand_chip *nand)
> +{
> +	writel(FSMC_DEVWID_8 | FSMC_DEVTYPE_NAND | FSMC_ENABLE | FSMC_WAITON,
> +			&fsmc_regs_p->genmemctrl_pc);
> +	writel(readl(&fsmc_regs_p->genmemctrl_pc) | FSMC_TCLR_1 | FSMC_TAR_1,
> +			&fsmc_regs_p->genmemctrl_pc);

Here you continue with two tabs...

> +	writel(FSMC_THIZ_1 | FSMC_THOLD_4 | FSMC_TWAIT_6 | FSMC_TSET_0,
> +		       &fsmc_regs_p->genmemctrl_comm);
> +	writel(FSMC_THIZ_1 | FSMC_THOLD_4 | FSMC_TWAIT_6 | FSMC_TSET_0,
> +		       &fsmc_regs_p->genmemctrl_attrib);

...and here with one tab plus 7 spaces.

> +	nand->ecc.layout  = &spear_nand_ecclayout;

There's an extra space before '=' here.

-Scott