[U-Boot] [PATCH 5/9] SPEAr600 SoC support added

Wolfgang Denk
2009-12-17T23:13:51Z

Dear Peter Tyser,

In message <1261090481.11634.5308.camel@localhost.localdomain> you wrote:
>
> > > I haven't looked at the code differences between the sp3xx boards, but
> > > you might be able to use 1 common board file/header file to support them
> > > all. For example, take a look at the M5475AFE_config rule in
> > > U-Boot's ./Makefile. Some extra code in the Makefile and some #ifdefs
> > > in the sp3xx code might accommodate all 3 boards.
> >
> > Extra code in the Makefile should not be needed any more.
>
> To be clear, you still think its a good idea to look into combining the
> similar boards, correct? I haven't dealt with the MKCONFIG voodoo, so

Yes, of course.

> maybe I chose a poor example. Perhaps the CPCI405 and friends is a
> better example?

Or this:

2485 P1011RDB_config \
2486 P1011RDB_NAND_config \
2487 P1011RDB_SDCARD_config \
2488 P1011RDB_SPIFLASH_config \
2489 P1020RDB_config \
2490 P1020RDB_NAND_config \
2491 P1020RDB_SDCARD_config \
2492 P1020RDB_SPIFLASH_config \
2493 P2010RDB_config \
2494 P2010RDB_NAND_config \
2495 P2010RDB_SDCARD_config \
2496 P2010RDB_SPIFLASH_config \
2497 P2020RDB_config \
2498 P2020RDB_NAND_config \
2499 P2020RDB_SDCARD_config \
2500 P2020RDB_SPIFLASH_config: unconfig
2501 @$(MKCONFIG) -t $(@:_config=) P1_P2_RDB ppc mpc85xx p1_p2_rdb freescale

No scripting any more in the Makefile :-)

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Vulcans worship peace above all.
-- McCoy, "Return to Tomorrow", stardate 4768.3