[U-Boot] [PATCH 4/9] usbd driver and usb boot firmware support for SPEAr SoCs

Vipin Kumar
2009-12-19T08:46:23Z

Dear Wolfgang,

> In message <83d1d72b0912182302m68e7ba06q5e23a695f85534f@mail.gmail.com> you wrote:
>>
>> >> --- a/common/main.c
>> >> +++ b/common/main.c
>> >> @@ -397,6 +397,7 @@ void main_loop (void)
>> >>
>> >> ? ? ? debug ("### main_loop: bootcmd=\"%s\"\n", s ? s : "<UNDEFI> NED>");
>> >>
>> >> +#if !defined(CONFIG_SPEAR_USBTTY)
>> >> ? ? ? if (bootdelay >= 0 && s && !abortboot (bootdelay)) {
>> >> ?# ifdef CONFIG_AUTOBOOT_KEYED
>> >> ? ? ? ? ? ? ? int prev = disable_ctrlc(1); ? ?/* dis> able Control C checking */
>> >> @@ -413,6 +414,7 @@ void main_loop (void)
>> >> ? ? ? ? ? ? ? disable_ctrlc(prev); ? ?/* restore Contr> ol C checking */
>> >> ?# endif
>> >> ? ? ? }
>> >> +# endif
>> >
>> > Why would this be needed?
>>
>> We also use u-boot as a firmware which runs on the board in a special
>> mode in which the firmware fetches and burns images into
>> NOR/NAND flashes. Under this mode, we would like to always jump to
>> u-boot prompt.
>
> This can be done by plain config settings. No need to chang ethe code.

I didn't get this. I want the uboot behavior as if bootdelay is set to -1.
And offcourse without changing bootdelay. I could not get if this can be
done by any plain config setting
Please let me know if I am missing something

>
>> Also, the bootdelay variable should remain unchanged as we save default
>> environment variables as well.
>
> Think of a different way to switch modes, please. I don't accept this
> change to common code.
>

Regards
Vipin