[U-Boot] [PATCH 4/9] usbd driver and usb boot firmware support for SPEAr SoCs

Wolfgang Denk
2009-12-19T07:24:06Z

Dear Vipin Kumar,

In message <83d1d72b0912182302m68e7ba06q5e23a695f85534f@mail.gmail.com> you wrote:
>
> >> --- a/common/main.c
> >> +++ b/common/main.c
> >> @@ -397,6 +397,7 @@ void main_loop (void)
> >>
> >> debug ("### main_loop: bootcmd=\"%s\"\n", s ? s : "<UNDEFI> NED>");
> >>
> >> +#if !defined(CONFIG_SPEAR_USBTTY)
> >> if (bootdelay >= 0 && s && !abortboot (bootdelay)) {
> >> # ifdef CONFIG_AUTOBOOT_KEYED
> >> int prev = disable_ctrlc(1); /* dis> able Control C checking */
> >> @@ -413,6 +414,7 @@ void main_loop (void)
> >> disable_ctrlc(prev); /* restore Contr> ol C checking */
> >> # endif
> >> }
> >> +# endif
> >
> > Why would this be needed?
>
> We also use u-boot as a firmware which runs on the board in a special
> mode in which the firmware fetches and burns images into
> NOR/NAND flashes. Under this mode, we would like to always jump to
> u-boot prompt.

This can be done by plain config settings. No need to chang ethe code.

> Also, the bootdelay variable should remain unchanged as we save default
> environment variables as well.

Think of a different way to switch modes, please. I don't accept this
change to common code.

> > Too long lines.
>
> I assume line length of 80 is acceptable. Right?

Maximum, right.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
What is mind? No matter. What is matter? Never mind.
-- Thomas Hewitt Key, 1799-1875