From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Breakage on arm/next
Date: Wed, 6 Jan 2010 16:47:14 -0600 [thread overview]
Message-ID: <20100106224714.GC28859@loki.buserror.net> (raw)
In-Reply-To: <4CCA9796C35A4D06B5395DDBC4664E36@sisodomain.com>
On Mon, Dec 21, 2009 at 04:30:40PM +0530, apgmoorthy wrote:
> Hunk 1:
> env_addr += CONFIG_ENV_ADDR & (onenand_mtd.eraseregions[0].erasesize-1);
>
> Hunk 2:
> env_addr += CONFIG_ENV_ADDR & (onenand_mtd.eraseregions[0].erasesize-1);
I'd say it should be the board config file's responsibility to provide a
CONFIG_ENV_ADDR that is properly block-aligned, regardless of what sort of
flash it's using.
> instr.len = onenand_mtd.eraseregions[0].erasesize;
It's unlikely at these block sizes, but theoretically the environment could
span multiple erase blocks.
Again, the board config file should supply a suitable CONFIG_ENV_SIZE.
-Scott
next prev parent reply other threads:[~2010-01-06 22:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-01 14:22 [U-Boot] Breakage on arm/next apgmoorthy
2009-12-01 14:39 ` Tom
2009-12-01 16:05 ` Alessandro Rubini
2009-12-02 12:13 ` apgmoorthy
2009-12-02 17:07 ` Scott Wood
2009-12-07 12:13 ` apgmoorthy
2009-12-07 17:26 ` Scott Wood
2009-12-10 4:15 ` apgmoorthy
2009-12-10 17:17 ` Scott Wood
2009-12-21 11:00 ` apgmoorthy
2010-01-06 22:47 ` Scott Wood [this message]
2009-12-17 15:53 ` Premi, Sanjeev
2009-12-18 11:01 ` apgmoorthy
-- strict thread matches above, loose matches on Subject: below --
2009-11-28 3:48 Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100106224714.GC28859@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox