From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Wed, 6 Jan 2010 16:47:14 -0600
Subject: [U-Boot] Breakage on arm/next
In-Reply-To: <4CCA9796C35A4D06B5395DDBC4664E36@sisodomain.com>
References: <4B152AAE.8090900@windriver.com>
	<EFAB0DC4B0834CDBAC4599012A2098CF@sisodomain.com>
	<20091201160555.GA4646@mail.gnudd.com>
	<DDCDEEBE8F324D348DAA4E7A380D6A76@sisodomain.com>
	<4B169EE0.9060400@freescale.com>
	<8CE7BC89E9714BB78EAB55CFF51076AD@sisodomain.com>
	<4B1D3ADB.6000603@freescale.com>
	<590CFEF8CED64C2E9C4BA6CD5BA617D0@sisodomain.com>
	<4B212D1A.5070105@freescale.com>
	<4CCA9796C35A4D06B5395DDBC4664E36@sisodomain.com>
Message-ID: <20100106224714.GC28859@loki.buserror.net>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Mon, Dec 21, 2009 at 04:30:40PM +0530, apgmoorthy wrote:
> Hunk 1:
> env_addr += CONFIG_ENV_ADDR & (onenand_mtd.eraseregions[0].erasesize-1);
> 
> Hunk 2:
> env_addr += CONFIG_ENV_ADDR & (onenand_mtd.eraseregions[0].erasesize-1);

I'd say it should be the board config file's responsibility to provide a
CONFIG_ENV_ADDR that is properly block-aligned, regardless of what sort of
flash it's using.

> instr.len = onenand_mtd.eraseregions[0].erasesize;

It's unlikely at these block sizes, but theoretically the environment could
span multiple erase blocks.

Again, the board config file should supply a suitable CONFIG_ENV_SIZE.

-Scott