From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] 83xx, uec: adjust enet_interface settings on the fly.
Date: Thu, 7 Jan 2010 18:59:44 -0600 [thread overview]
Message-ID: <20100107185944.189fdff3.kim.phillips@freescale.com> (raw)
In-Reply-To: <4B4594DC.3090809@denx.de>
On Thu, 7 Jan 2010 09:01:32 +0100
Heiko Schocher <hs@denx.de> wrote:
> static void adjust_link(struct eth_device *dev)
> {
> uec_private_t *uec = (uec_private_t *)dev->priv;
> @@ -547,6 +617,8 @@ static void adjust_link(struct eth_device *dev)
> dev->name, mii_info->speed);
> break;
> }
> + } else if (uec->uec_info->uf_info.eth_type == FAST_ETH) {
> + adjust_fast_enet_interface(mii_info->speed, dev);
> }
did you make any effort to refactor this into the existing eth_type ==
GIGA_ETH code? I'm not sure why that code became conditional in commit
24c3aca3f1358b113d3215adb5433b156e99f72b "mpc83xx: Add support for the
MPC832XEMDS board" in the first place - Dave?
Kim
next prev parent reply other threads:[~2010-01-08 0:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-07 8:01 [U-Boot] 83xx, uec: adjust enet_interface settings on the fly Heiko Schocher
2010-01-08 0:59 ` Kim Phillips [this message]
2010-01-08 3:11 ` Liu Dave-R63238
2010-01-08 7:37 ` Heiko Schocher
2010-01-08 7:52 ` Liu Dave-R63238
2010-01-08 8:12 ` Heiko Schocher
2010-01-08 8:14 ` Liu Dave-R63238
2010-01-19 6:49 ` Andy Fleming
2010-01-19 8:42 ` Heiko Schocher
2010-01-20 8:04 ` [U-Boot] 83xx, uec: split enet_interface in two variables, was: " Heiko Schocher
2010-02-01 5:25 ` Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100107185944.189fdff3.kim.phillips@freescale.com \
--to=kim.phillips@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox