From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] MUSB-UDC issues and fixes
Date: Mon, 11 Jan 2010 16:35:35 -0500 [thread overview]
Message-ID: <201001111635.35934.vapier@gentoo.org> (raw)
In-Reply-To: <a46a26fd1001111200x155b0419p987c7e851dbab73d@mail.gmail.com>
On Monday 11 January 2010 15:00:40 Juha Kuikka wrote:
> 2. On DM850 the MUSB interrupts are read from a wrapper, not from MUSB
> block . Add optional interface function to read-and-clear interrupts.
>
> +#ifndef CONFIG_MUSB_SOC_IRQ
> +static void musb_get_interrupts(u8 *usb, u16 *rx, u16 *tx)
> +{
> + *usb = readb(&musbr->intrusb);
> + *rx = readw(&musbr->intrrx);
> + *tx = readw(&musbr->intrtx);
> +}
> +#else
> +extern void musb_get_interrupts(u8 *usb, u16 *rx, u16 *tx);
> +#endif
this looks like a static MUSB implementation rather than a config option a
user/board would control, right ? so perhaps we should stick with the
"internal" symbol naming rather than CONFIG_MUSB_xxx ... e.g. the way we're
handling dynamic fifos and/or multipoint.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100111/f787f2ae/attachment.pgp
next prev parent reply other threads:[~2010-01-11 21:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-11 20:00 [U-Boot] [RFC] MUSB-UDC issues and fixes Juha Kuikka
2010-01-11 21:35 ` Mike Frysinger [this message]
2010-01-12 13:50 ` Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001111635.35934.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox