From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] SPI: Fix 32 bit transfers in mxc_spi.c
Date: Mon, 18 Jan 2010 00:02:33 +0100 [thread overview]
Message-ID: <20100117230233.23CFDC88AE@gemini.denx.de> (raw)
In-Reply-To: <1263726375-4929-1-git-send-email-lilja.magnus@gmail.com>
Dear Feng,
can you please take care of this?
In message <1263726375-4929-1-git-send-email-lilja.magnus@gmail.com> Magnus Lilja wrote:
> Commit f9b6a1575d9f1ca192e4cb60e547aa66f08baa3f, "i.MX31: fix SPI
> driver for shorter than 32 bit" broke 32 bit transfers. This patch
> makes single 32 bit transfer work again.
>
> Transfer lengths that are known not to work will abort and print
> an error message.
>
> Tested on i.MX31 Litekit and i.MX31 PDK using 32 bit transfers to
> the MC13783/ATLAS chip (using the 'date' command).
>
> Signed-off-by: Magnus Lilja <lilja.magnus@gmail.com>
> ---
>
> As discussed on the mailing list, Guennadi Liakhovetski thinks that
> all transfers > 16 bits are broken. This patch fixes the 32 bit case
> and makes sure the user is notified if a broken bitlength is used.
>
> drivers/spi/mxc_spi.c | 9 +++++++++
> 1 files changed, 9 insertions(+), 0 deletions(-)
Acked-by: Wolfgang Denk <wd@denx.de>
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A secure program has to be robust: it must be able to deal with
conditions that "can't happen", whether user input, program error or
library/etc. This is basic damage control. Buffer overflow errors
have nothing to do with security, but everything with stupidity.
-- Wietse Venema in <5cnqm3$8r9@spike.porcupine.org>
next prev parent reply other threads:[~2010-01-17 23:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-17 11:06 [U-Boot] [PATCH v2] SPI: Fix 32 bit transfers in mxc_spi.c Magnus Lilja
2010-01-17 23:02 ` Wolfgang Denk [this message]
2010-01-23 17:08 ` Magnus Lilja
2010-02-07 18:43 ` Tom
2010-02-08 20:06 ` Magnus Lilja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100117230233.23CFDC88AE@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox