public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 5/9] serial_mxc: add support for MX51 processor
Date: Mon, 18 Jan 2010 09:45:43 +0100	[thread overview]
Message-ID: <20100118084543.3DF243F6C0@gemini.denx.de> (raw)
In-Reply-To: <4B540AB9.5080602@denx.de>

Dear Stefano Babic,

In message <4B540AB9.5080602@denx.de> you wrote:
>
> > What happens if - for example - CONFIG_SYS_MX51_UART1 _and_
> > CONFIG_SYS_MX51_UART2 are defiend? How is CONFIG_SERIAL_MULTI going to
> > be supported?
> 
> The patch adds only support for the i.MX51 and does

Something missing here ???

> I understand what you mean. However, the driver at moment has the same
> problem with other processors (MX27, MX31). Should be not better to fix
> this issue with another patch that has nothing to do with i.MX51 ?

That's OK with me. But then, this shouldbe documented so nobody tries
to enable more than one serial port.

> There is already a patch by John Rigby to drop them and using a general
> function for all of them. However, you are reviewing my first patchset.

Sorry, I only noticed this later :-(

> In V2 I have already removed the special implementation for MX51 and I
> have added the general function imx_get_uartclk(), as John implemented
> for the other MX processors.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"There are three principal ways to lose money: wine, women,  and  en-
gineers.  While  the first two are more pleasant, the third is by far
the more certain."                      -- Baron Rothschild, ca. 1800

  reply	other threads:[~2010-01-18  8:45 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-11 12:25 [U-Boot] MX51 Support in u-boot Stefano Babic
2010-01-11 12:25 ` [U-Boot] [PATCH 1/9] mkimage: Add Freescale imx Boot Image support (imximage) Stefano Babic
2010-01-11 12:25   ` [U-Boot] [PATCH 2/9] MX51: Add initial support for the Freescale MX51 Stefano Babic
2010-01-11 12:25     ` [U-Boot] [PATCH 3/9] MX51: Add register definitions Stefano Babic
2010-01-11 12:25       ` [U-Boot] [PATCH 4/9] MX51: Add pin and multiplexer definitions Stefano Babic
2010-01-11 12:25         ` [U-Boot] [PATCH 5/9] serial_mxc: add support for MX51 processor Stefano Babic
2010-01-11 12:25           ` [U-Boot] [PATCH 6/9] fec_mxc: " Stefano Babic
2010-01-11 12:25             ` [U-Boot] [PATCH 7/9] fsl_esdhc: add support for mx51 processor Stefano Babic
2010-01-11 12:25               ` [U-Boot] [PATCH 8/9] mmc: check correctness of the voltage mask in ocr Stefano Babic
2010-01-11 12:26                 ` [U-Boot] [PATCH 9/9] Add initial support for Freescale mx51evk board Stefano Babic
2010-01-11 17:55                   ` Fabio Estevam
2010-01-11 23:53                   ` Fabio Estevam
2010-01-17 13:05                   ` Wolfgang Denk
2010-01-18  7:34                     ` Stefano Babic
2010-01-18  8:50                       ` Wolfgang Denk
2010-01-18 10:25                         ` Stefano Babic
2010-01-17 12:46               ` [U-Boot] [PATCH 7/9] fsl_esdhc: add support for mx51 processor Wolfgang Denk
2010-01-18  8:53                 ` Stefano Babic
2010-01-18  9:16                   ` Wolfgang Denk
2010-01-17 12:34             ` [U-Boot] [PATCH 6/9] fec_mxc: add support for MX51 processor Wolfgang Denk
2010-01-18  9:35               ` Stefano Babic
2010-01-18 11:24                 ` Wolfgang Denk
2010-01-18 12:19                   ` Stefano Babic
2010-01-18 17:02                     ` John Rigby
2010-01-17 11:23           ` [U-Boot] [PATCH 5/9] serial_mxc: " Wolfgang Denk
2010-01-18  7:16             ` Stefano Babic
2010-01-18  8:45               ` Wolfgang Denk [this message]
2010-01-11 15:58         ` [U-Boot] [PATCH 4/9] MX51: Add pin and multiplexer definitions Detlev Zundel
2010-01-17 11:19         ` Wolfgang Denk
2010-01-11 15:56       ` [U-Boot] [PATCH 3/9] MX51: Add register definitions Detlev Zundel
2010-01-17 11:16       ` Wolfgang Denk
2010-01-18  6:40         ` Stefano Babic
2010-01-18  7:53           ` Wolfgang Denk
2010-01-11 15:48     ` [U-Boot] [PATCH 2/9] MX51: Add initial support for the Freescale MX51 Detlev Zundel
2010-01-11 15:58       ` Stefano Babic
2010-01-11 16:07         ` Detlev Zundel
2010-01-11 15:59     ` Detlev Zundel
2010-01-17 10:28     ` Wolfgang Denk
2010-01-18  7:05       ` Stefano Babic
2010-01-18  8:42         ` Wolfgang Denk
2010-01-11 15:43   ` [U-Boot] [PATCH 1/9] mkimage: Add Freescale imx Boot Image support (imximage) Detlev Zundel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100118084543.3DF243F6C0@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox