From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Fix breakage in SMC EEPROM standalone applications
Date: Mon, 18 Jan 2010 17:02:16 -0500 [thread overview]
Message-ID: <201001181702.17348.vapier@gentoo.org> (raw)
In-Reply-To: <1263843331-30089-1-git-send-email-biggerbadderben@gmail.com>
On Monday 18 January 2010 14:35:31 Ben Warren wrote:
> --- a/examples/standalone/smc911x_eeprom.c
> +++ b/examples/standalone/smc911x_eeprom.c
> @@ -324,7 +317,6 @@ int smc911x_eeprom(int argc, char *argv[])
> {
> /* Avoid initializing on stack as gcc likes to call memset() */
> struct eth_device dev;
> - dev.name = __func__;
> dev.iobase = CONFIG_SMC911X_BASE;
the .name was added because some patch was changing smc911x.h to use it in
error reporting, but i guess that never made it in as the current header uses
DRIVERNAME ...
Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100118/cad176e5/attachment.pgp
next prev parent reply other threads:[~2010-01-18 22:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 19:35 [U-Boot] [PATCH] Fix breakage in SMC EEPROM standalone applications Ben Warren
2010-01-18 19:44 ` Dirk Behme
2010-01-18 22:02 ` Mike Frysinger [this message]
2010-01-18 23:06 ` Wolfgang Denk
[not found] ` <4B54D424.304@windriver.com>
2010-01-18 23:15 ` Ben Warren
2010-01-18 23:42 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001181702.17348.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox