From: Alessandro Rubini <rubini-list@gnudd.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] Add Nomadik board "usb-s8815" by Calao vendor
Date: Tue, 19 Jan 2010 00:54:34 +0100 [thread overview]
Message-ID: <20100118235434.GA8346@morgana.gnudd.com> (raw)
In-Reply-To: <20100118233218.94F213F6C0@gemini.denx.de>
[I'm re-adding Gregory Hermant in Cc:, while my message had the Cc:
explicit, the copy I got from the list and your reply had no such header]
> I don't like to see such heavy copying of code.
I understand your point of view (although I didn't use
--find-copies-harder you probably wouldn't have noticed).
However, these are really different boards from different vendors.
The Calao one is a stripped-down version of the development system,
not uncommon to what happens elsewhere.
Where do you suggest to place common code?
While it is true that, currently, platform.S can be placed in common
nomadik code, the file could as well be cleaned up of unneeded or
redundant stuff, which is different in the two boards. (The file is
something I got from the vendor and would benefit from some cleanup,
now that I know more of the various register sets in the SoC).
> Note that many of the existing diffrences can be avoided easily and
> without need for #ifdef's:
You are right. But one LCD needs a turn-on-backlight method, while the
other does not. If I place it on cpu/arm926ejs/nomadik/ we'll have
problems when another board mounts a different display.
I'll try to factorize as I can, but I'm not sure it's the right thing
to do. Will respin the patch by tomorrow night.
/alessandro
next prev parent reply other threads:[~2010-01-18 23:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-18 22:13 [U-Boot] [PATCH 0/2] Add a new Nomadik board Alessandro Rubini
2010-01-18 22:13 ` [U-Boot] [PATCH 1/2] NAND Nomadik: add CONFIG_NAND_NOMADIK_16BIT option Alessandro Rubini
2010-01-18 23:26 ` Wolfgang Denk
2010-01-18 23:31 ` Scott Wood
2010-01-19 0:02 ` Alessandro Rubini
2010-01-18 22:13 ` [U-Boot] [PATCH 2/2] Add Nomadik board "usb-s8815" by Calao vendor Alessandro Rubini
2010-01-18 23:32 ` Wolfgang Denk
2010-01-18 23:54 ` Alessandro Rubini [this message]
2010-01-22 18:36 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100118235434.GA8346@morgana.gnudd.com \
--to=rubini-list@gnudd.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox