From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Thu, 21 Jan 2010 08:45:10 +0100 Subject: [U-Boot] [PATCH] ppc4xx: Allow setting a single SPD EEPROM address for DDR2 DIMMs In-Reply-To: <1263928746-11149-1-git-send-email-felix@embedded-sol.com> References: <> <1263928746-11149-1-git-send-email-felix@embedded-sol.com> Message-ID: <201001210845.10411.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 19 January 2010 20:19:06 Felix Radensky wrote: > On platforms where SPD EEPROM and another EEPROM have adjacent > I2C addresses SPD_EEPROM_ADDRESS should be defined as a single > element array, otherwise DDR2 setup code would fail with the > following error: > > ERROR: Unknown DIMM detected in slot 1 > > However, fixing SPD_EEPROM_ADDRESS would result in another > error: > > ERROR: DIMM's DDR1 and DDR2 type can not be mixed. > > This happens because initdram() routine does not explicitly > initialize dimm_populated array. This patch fixes the problem. Applied to u-boot-ppc4xx/master. Thanks. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de