From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Frysinger Date: Thu, 21 Jan 2010 18:01:47 -0500 Subject: [U-Boot] [PATCH] smc911x driver: cleanup smc911x_initialize() In-Reply-To: <20100121212924.GC16182@darwin> References: <20100121212924.GC16182@darwin> Message-ID: <201001211801.48290.vapier@gentoo.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Thursday 21 January 2010 16:29:24 Matthias Kaehlcke wrote: > smc911x_initialize(): remove unecessary call to free() and > return 0 in case of failure instead of -1 > > Signed-off-by: Matthias Kaehlcke > --- > drivers/net/smc911x.c | 3 +-- > 1 files changed, 1 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c > index 5d51406..f2b5895 100644 > --- a/drivers/net/smc911x.c > +++ b/drivers/net/smc911x.c > @@ -242,8 +242,7 @@ int smc911x_initialize(u8 dev_num, int base_addr) > > dev = malloc(sizeof(*dev)); > if (!dev) { > - free(dev); OK > - return -1; > + return 0; this is an error path, so i think -1 is correct. if you're out of memory, increase your malloc region. -mike -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: This is a digitally signed message part. Url : http://lists.denx.de/pipermail/u-boot/attachments/20100121/1b4583b7/attachment.pgp