From: Matthias Kaehlcke <matthias@kaehlcke.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cs8900 driver: cleanup cs8900_initialize()
Date: Thu, 21 Jan 2010 21:56:46 +0100 [thread overview]
Message-ID: <20100121205646.GZ16182@darwin> (raw)
cs8900_initialize(): remove unecessary calls to free(), fix memory leak and
report errors in the return value
Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
---
drivers/net/cs8900.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/cs8900.c b/drivers/net/cs8900.c
index df36004..7895048 100644
--- a/drivers/net/cs8900.c
+++ b/drivers/net/cs8900.c
@@ -308,15 +308,14 @@ int cs8900_initialize(u8 dev_num, int base_addr)
dev = malloc(sizeof(*dev));
if (!dev) {
- free(dev);
- return 0;
+ return -1;
}
memset(dev, 0, sizeof(*dev));
priv = malloc(sizeof(*priv));
if (!priv) {
- free(priv);
- return 0;
+ free(dev);
+ return -1;
}
memset(priv, 0, sizeof(*priv));
priv->regs = (struct cs8900_regs *)base_addr;
--
1.6.3.1
next reply other threads:[~2010-01-21 20:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 20:56 Matthias Kaehlcke [this message]
2010-01-21 21:10 ` [U-Boot] [PATCH] cs8900 driver: cleanup cs8900_initialize() Ben Warren
2010-01-21 21:12 ` Matthias Kaehlcke
2010-01-21 22:02 ` Wolfgang Denk
2010-01-21 22:01 ` Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100121205646.GZ16182@darwin \
--to=matthias@kaehlcke.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox