[U-Boot] [PATCH] smc911x driver: cleanup smc911x_initialize()

[Matthias Kaehlcke <matthias@kaehlcke.net>]

hi mike,

El Thu, Jan 21, 2010 at 06:01:47PM -0500 Mike Frysinger ha dit:

> On Thursday 21 January 2010 16:29:24 Matthias Kaehlcke wrote:
> > smc911x_initialize(): remove unecessary call to free() and
> > return 0 in case of failure instead of -1
> > 
> > Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
> > ---
> >  drivers/net/smc911x.c |    3 +--
> >  1 files changed, 1 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
> > index 5d51406..f2b5895 100644
> > --- a/drivers/net/smc911x.c
> > +++ b/drivers/net/smc911x.c
> > @@ -242,8 +242,7 @@ int smc911x_initialize(u8 dev_num, int base_addr)
> > 
> >  	dev = malloc(sizeof(*dev));
> >  	if (!dev) {
> > -		free(dev);
> 
> OK
> 
> > -		return -1;
> > +		return 0;
> 
> this is an error path, so i think -1 is correct.  if you're out of memory, 
> increase your malloc region.

that's what I thought in the first place, but Ben Warren told me that
in the initialize function the return value indicates the number of
devices that were initialized (see
http://lists.denx.de/pipermail/u-boot/2010-January/066859.html)

best regards

-- 
Matthias Kaehlcke
Embedded Linux Developer
Barcelona

                Don't walk behind me, I may not lead
             Don't walk in front of me, I may not follow
                Just walk beside me and be my friend
                          (Albert Camus)
                                                                 .''`.
    using free software / Debian GNU/Linux | http://debian.org  : :'  :
                                                                `. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4                  `-