public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH v2] ppc4xx: Fix sending type 1 PCI transactions
@ 2010-01-22 23:35 Felix Radensky
  2010-01-23  8:26 ` Stefan Roese
  2010-01-23  8:28 ` Stefan Roese
  0 siblings, 2 replies; 3+ messages in thread
From: Felix Radensky @ 2010-01-22 23:35 UTC (permalink / raw)
  To: u-boot

The list of 4xx SoCs that should send type 1 PCI transactions
is not defined correctly. As a result PCI-PCI bridges and devices
behind them are not identified. The following 4xx variants should
send type 1 transactions: 440GX, 440GP, 440SP, 440SPE, 460EX and 460GT.

Signed-off-by: Felix Radensky <felix@embedded-sol.com>
---
v2: Removed 460SX from the list, it has no PCI controller.
    Fixed commit message

 drivers/pci/pci_indirect.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/drivers/pci/pci_indirect.c b/drivers/pci/pci_indirect.c
index ab51f8d..2070d01 100644
--- a/drivers/pci/pci_indirect.c
+++ b/drivers/pci/pci_indirect.c
@@ -59,7 +59,8 @@ indirect_##rw##_config_##size(struct pci_controller *hose,               \
 	cfg_##rw(val, hose->cfg_data + (offset & mask), type, op);       \
 	return 0;                                                        \
 }
-#elif defined(CONFIG_440GX) || defined(CONFIG_440EP) || defined(CONFIG_440GR) || defined(CONFIG_440SPE)
+#elif defined(CONFIG_440GX)  || defined(CONFIG_440GP) || defined(CONFIG_440SP) || \
+      defined(CONFIG_440SPE) || defined(CONFIG_460EX) || defined(CONFIG_460GT)
 #define INDIRECT_PCI_OP(rw, size, type, op, mask)			 \
 static int								 \
 indirect_##rw##_config_##size(struct pci_controller *hose,		 \
-- 
1.5.4.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH v2] ppc4xx: Fix sending type 1 PCI transactions
  2010-01-22 23:35 [U-Boot] [PATCH v2] ppc4xx: Fix sending type 1 PCI transactions Felix Radensky
@ 2010-01-23  8:26 ` Stefan Roese
  2010-01-23  8:28 ` Stefan Roese
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2010-01-23  8:26 UTC (permalink / raw)
  To: u-boot

On Saturday 23 January 2010 00:35:24 Felix Radensky wrote:
> The list of 4xx SoCs that should send type 1 PCI transactions
> is not defined correctly. As a result PCI-PCI bridges and devices
> behind them are not identified. The following 4xx variants should
> send type 1 transactions: 440GX, 440GP, 440SP, 440SPE, 460EX and 460GT.
>
> Signed-off-by: Felix Radensky <felix@embedded-sol.com>
> ---
> v2: Removed 460SX from the list, it has no PCI controller.
>     Fixed commit message

Ups. I already applied the first version of this patch. Will remove this again 
and take this one instead. Thanks.
 
Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [U-Boot] [PATCH v2] ppc4xx: Fix sending type 1 PCI transactions
  2010-01-22 23:35 [U-Boot] [PATCH v2] ppc4xx: Fix sending type 1 PCI transactions Felix Radensky
  2010-01-23  8:26 ` Stefan Roese
@ 2010-01-23  8:28 ` Stefan Roese
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Roese @ 2010-01-23  8:28 UTC (permalink / raw)
  To: u-boot

On Saturday 23 January 2010 00:35:24 Felix Radensky wrote:
> The list of 4xx SoCs that should send type 1 PCI transactions
> is not defined correctly. As a result PCI-PCI bridges and devices
> behind them are not identified. The following 4xx variants should
> send type 1 transactions: 440GX, 440GP, 440SP, 440SPE, 460EX and 460GT.
> 
> Signed-off-by: Felix Radensky <felix@embedded-sol.com>
> ---
> v2: Removed 460SX from the list, it has no PCI controller.
>     Fixed commit message

Applied to u-boot-ppc4xx/master. Thanks.
 
Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-01-23  8:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-22 23:35 [U-Boot] [PATCH v2] ppc4xx: Fix sending type 1 PCI transactions Felix Radensky
2010-01-23  8:26 ` Stefan Roese
2010-01-23  8:28 ` Stefan Roese

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox