From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 08/12] macb: Fix return values of macb_eth_initialize()
Date: Sun, 24 Jan 2010 05:59:12 -0500 [thread overview]
Message-ID: <201001240559.13412.vapier@gentoo.org> (raw)
In-Reply-To: <20100124100746.GN18402@darwin>
On Sunday 24 January 2010 05:07:46 Matthias Kaehlcke wrote:
> --- a/drivers/net/macb.c
> +++ b/drivers/net/macb.c
> @@ -500,7 +500,7 @@ int macb_eth_initialize(int id, void *regs, unsigned
> int phy_addr) macb = malloc(sizeof(struct macb_device));
> if (!macb) {
> printf("Error: Failed to allocate memory for MACB%d\n", id);
> - return -1;
> + return 0;
> }
this is an error path thus the current code is correct
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100124/9cd210ad/attachment.pgp
next prev parent reply other threads:[~2010-01-24 10:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1264327272.git.matthias@kaehlcke.net>
2010-01-24 10:07 ` [U-Boot] [PATCH 01/12] 4xx_enet: Fix return value of ppc_4xx_eth_initialize() Matthias Kaehlcke
2010-01-24 10:07 ` [U-Boot] [PATCH 02/12] bfin_EMAC: Fix return value of bfin_EMAC_initialize() Matthias Kaehlcke
2010-01-24 10:07 ` [U-Boot] [PATCH 03/12] dnet: Fix return value of dnet_eth_initialize() Matthias Kaehlcke
2010-01-24 10:07 ` [U-Boot] [PATCH 04/12] fec_mxc: Fix return values of fec_probe() Matthias Kaehlcke
2010-01-24 10:59 ` Mike Frysinger
2010-01-24 10:07 ` [U-Boot] [PATCH 05/12] fsl_mcdmafec: Fix return value of mcdmafec_initialize() Matthias Kaehlcke
2010-01-24 10:07 ` [U-Boot] [PATCH 06/12] INCA IP: Fix return value of inca_switch_initialize() Matthias Kaehlcke
2010-01-24 10:07 ` [U-Boot] [PATCH 07/12] lan91c96: Fix return value of lan91c96_initialize() Matthias Kaehlcke
2010-01-24 10:07 ` [U-Boot] [PATCH 08/12] macb: Fix return values of macb_eth_initialize() Matthias Kaehlcke
2010-01-24 10:59 ` Mike Frysinger [this message]
2010-01-24 10:07 ` [U-Boot] [PATCH 09/12] mcffec: Fix return value of mcffec_initialize() Matthias Kaehlcke
2010-01-24 10:07 ` [U-Boot] [PATCH 10/12] plb2800: Fix return values of plb2800_eth_initialize() Matthias Kaehlcke
2010-01-24 10:58 ` [U-Boot] [PATCH 10/12] plb2800: Fix return values of plb2800_eth_initialize () Mike Frysinger
2010-01-24 10:07 ` [U-Boot] [PATCH 11/12] sh_eth: Fix return value of sh_eth_initialize() Matthias Kaehlcke
2010-01-24 10:57 ` Mike Frysinger
2010-01-24 13:10 ` Matthias Kaehlcke
2010-01-24 10:08 ` [U-Boot] [PATCH 12/12] smc91111: Fix return value of smc91111_initialize() Matthias Kaehlcke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201001240559.13412.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox