* [U-Boot] [PATCH 00/12] net: Fix return values of xxx_initialize()
@ 2010-01-24 10:07 Matthias Kaehlcke
2010-01-24 14:23 ` Wolfgang Denk
2010-01-24 17:17 ` Ben Warren
0 siblings, 2 replies; 4+ messages in thread
From: Matthias Kaehlcke @ 2010-01-24 10:07 UTC (permalink / raw)
To: u-boot
Fix network drivers that don't return the number of initialized
devices upon successful initialization and 0 in case of failure
Matthias Kaehlcke (12):
4xx_enet: Fix return value of ppc_4xx_eth_initialize()
bfin_EMAC: Fix return value of bfin_EMAC_initialize()
dnet: Fix return value of dnet_eth_initialize()
fec_mxc: Fix return values of fec_probe()
fsl_mcdmafec: Fix return value of mcdmafec_initialize()
INCA IP: Fix return value of inca_switch_initialize()
lan91c96: Fix return value of lan91c96_initialize()
macb: Fix return values of macb_eth_initialize()
mcffec: Fix return value of mcffec_initialize()
plb2800: Fix return values of plb2800_eth_initialize()
sh_eth: Fix return value of sh_eth_initialize()
smc91111: Fix return value of smc91111_initialize()
drivers/net/4xx_enet.c | 2 +-
drivers/net/bfin_mac.c | 2 +-
drivers/net/dnet.c | 2 +-
drivers/net/fec_mxc.c | 4 ++--
drivers/net/fsl_mcdmafec.c | 2 +-
drivers/net/inca-ip_sw.c | 2 +-
drivers/net/lan91c96.c | 2 +-
drivers/net/macb.c | 4 ++--
drivers/net/mcffec.c | 2 +-
drivers/net/plb2800_eth.c | 4 ++--
drivers/net/sh_eth.c | 6 +++---
drivers/net/smc91111.c | 2 +-
12 files changed, 17 insertions(+), 17 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 00/12] net: Fix return values of xxx_initialize()
2010-01-24 10:07 [U-Boot] [PATCH 00/12] net: Fix return values of xxx_initialize() Matthias Kaehlcke
@ 2010-01-24 14:23 ` Wolfgang Denk
2010-01-24 17:17 ` Ben Warren
1 sibling, 0 replies; 4+ messages in thread
From: Wolfgang Denk @ 2010-01-24 14:23 UTC (permalink / raw)
To: u-boot
Dear Matthias Kaehlcke,
In message <20100124100708.GF18402@darwin> you wrote:
> Fix network drivers that don't return the number of initialized
> devices upon successful initialization and 0 in case of failure
>
> Matthias Kaehlcke (12):
> 4xx_enet: Fix return value of ppc_4xx_eth_initialize()
> bfin_EMAC: Fix return value of bfin_EMAC_initialize()
> dnet: Fix return value of dnet_eth_initialize()
> fec_mxc: Fix return values of fec_probe()
> fsl_mcdmafec: Fix return value of mcdmafec_initialize()
> INCA IP: Fix return value of inca_switch_initialize()
> lan91c96: Fix return value of lan91c96_initialize()
> macb: Fix return values of macb_eth_initialize()
> mcffec: Fix return value of mcffec_initialize()
> plb2800: Fix return values of plb2800_eth_initialize()
> sh_eth: Fix return value of sh_eth_initialize()
> smc91111: Fix return value of smc91111_initialize()
...
> 12 files changed, 17 insertions(+), 17 deletions(-)
Why did you split this into 12 commits? It is one logical change, and
should be applied in a single clommit.
Ben, if you should accept this stuff, then please squash all these 12
patches into a single commit.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I have yet to add the ESP-driver to the kernel to read the mind of
the user... - Linus Torvalds in
<Pine.LNX.3.91.960426110644.24860I-100000@linux.cs.Helsinki.FI>
^ permalink raw reply [flat|nested] 4+ messages in thread* [U-Boot] [PATCH 00/12] net: Fix return values of xxx_initialize()
2010-01-24 10:07 [U-Boot] [PATCH 00/12] net: Fix return values of xxx_initialize() Matthias Kaehlcke
2010-01-24 14:23 ` Wolfgang Denk
@ 2010-01-24 17:17 ` Ben Warren
2010-01-24 17:18 ` Matthias Kaehlcke
1 sibling, 1 reply; 4+ messages in thread
From: Ben Warren @ 2010-01-24 17:17 UTC (permalink / raw)
To: u-boot
Hi Matthias,
On Sun, Jan 24, 2010 at 2:07 AM, Matthias Kaehlcke <matthias@kaehlcke.net>wrote:
> Fix network drivers that don't return the number of initialized
> devices upon successful initialization and 0 in case of failure
>
> Matthias Kaehlcke (12):
> 4xx_enet: Fix return value of ppc_4xx_eth_initialize()
> bfin_EMAC: Fix return value of bfin_EMAC_initialize()
> dnet: Fix return value of dnet_eth_initialize()
> fec_mxc: Fix return values of fec_probe()
> fsl_mcdmafec: Fix return value of mcdmafec_initialize()
> INCA IP: Fix return value of inca_switch_initialize()
> lan91c96: Fix return value of lan91c96_initialize()
> macb: Fix return values of macb_eth_initialize()
> mcffec: Fix return value of mcffec_initialize()
> plb2800: Fix return values of plb2800_eth_initialize()
> sh_eth: Fix return value of sh_eth_initialize()
> smc91111: Fix return value of smc91111_initialize()
>
> drivers/net/4xx_enet.c | 2 +-
> drivers/net/bfin_mac.c | 2 +-
> drivers/net/dnet.c | 2 +-
> drivers/net/fec_mxc.c | 4 ++--
> drivers/net/fsl_mcdmafec.c | 2 +-
> drivers/net/inca-ip_sw.c | 2 +-
> drivers/net/lan91c96.c | 2 +-
> drivers/net/macb.c | 4 ++--
> drivers/net/mcffec.c | 2 +-
> drivers/net/plb2800_eth.c | 4 ++--
> drivers/net/sh_eth.c | 6 +++---
> drivers/net/smc91111.c | 2 +-
> 12 files changed, 17 insertions(+), 17 deletions(-)
>
> I appreciate your enthusiasm, but don't see the point of changing all
return codes to the current state, when I recently mentioned that the
current state is confusing. Things have been this way for some time, so
there's no urgency to fix up all existing drivers. Hopefully tonight I'll
get to the core changes, then we can fix up all drivers at once to a more
'final' state.
regards,
Ben
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 00/12] net: Fix return values of xxx_initialize()
2010-01-24 17:17 ` Ben Warren
@ 2010-01-24 17:18 ` Matthias Kaehlcke
0 siblings, 0 replies; 4+ messages in thread
From: Matthias Kaehlcke @ 2010-01-24 17:18 UTC (permalink / raw)
To: u-boot
El Sun, Jan 24, 2010 at 09:17:16AM -0800 Ben Warren ha dit:
> Hi Matthias,
>
> On Sun, Jan 24, 2010 at 2:07 AM, Matthias Kaehlcke <matthias@kaehlcke.net>
> wrote:
>
> Fix network drivers that don't return the number of initialized
> devices upon successful initialization and 0 in case of failure
>
> Matthias Kaehlcke (12):
> 4xx_enet: Fix return value of ppc_4xx_eth_initialize()
> bfin_EMAC: Fix return value of bfin_EMAC_initialize()
> dnet: Fix return value of dnet_eth_initialize()
> fec_mxc: Fix return values of fec_probe()
> fsl_mcdmafec: Fix return value of mcdmafec_initialize()
> INCA IP: Fix return value of inca_switch_initialize()
> lan91c96: Fix return value of lan91c96_initialize()
> macb: Fix return values of macb_eth_initialize()
> mcffec: Fix return value of mcffec_initialize()
> plb2800: Fix return values of plb2800_eth_initialize()
> sh_eth: Fix return value of sh_eth_initialize()
> smc91111: Fix return value of smc91111_initialize()
>
> drivers/net/4xx_enet.c | 2 +-
> drivers/net/bfin_mac.c | 2 +-
> drivers/net/dnet.c | 2 +-
> drivers/net/fec_mxc.c | 4 ++--
> drivers/net/fsl_mcdmafec.c | 2 +-
> drivers/net/inca-ip_sw.c | 2 +-
> drivers/net/lan91c96.c | 2 +-
> drivers/net/macb.c | 4 ++--
> drivers/net/mcffec.c | 2 +-
> drivers/net/plb2800_eth.c | 4 ++--
> drivers/net/sh_eth.c | 6 +++---
> drivers/net/smc91111.c | 2 +-
> 12 files changed, 17 insertions(+), 17 deletions(-)
>
> I appreciate your enthusiasm, but don't see the point of changing all
> return codes to the current state, when I recently mentioned that the
> current state is confusing. Things have been this way for some time, so
> there's no urgency to fix up all existing drivers. Hopefully tonight I'll
> get to the core changes, then we can fix up all drivers at once to a more
> 'final' state.
ok
--
Matthias Kaehlcke
Embedded Linux Developer
Barcelona
Insanity: doing the same thing over and over
again and expecting different results
(Albert Einstein)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-01-24 17:18 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-24 10:07 [U-Boot] [PATCH 00/12] net: Fix return values of xxx_initialize() Matthias Kaehlcke
2010-01-24 14:23 ` Wolfgang Denk
2010-01-24 17:17 ` Ben Warren
2010-01-24 17:18 ` Matthias Kaehlcke
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox