[U-Boot] SPI and spi_cs_activate

Mike Frysinger
2010-01-29T16:11:36Z

On Friday 29 January 2010 10:59:28 Wolfgang Wegner wrote:
> I am trying to get the spi_mmc driver by Robert Selberg and Hans Eklund
> to run on my new Coldfire board. (The driver was posted as a patch some
> time ago, clearly marked as not ready for mainline. I just did not figure
> out the correct search term to give the message ID.)
>
> Now I am running into problems because the driver uses spi_cs_[de]activate,
> which is rather useless on coldfire which does automatic cs.
>
> Looking through other drivers' code it seems to me that spi_cs_[de]activate
> was never meant to be called from anybody else but some special SPI
> drivers that can not aotumatically control cs lines or for systems
> where SPI is done in software and so setting the appropriate GPIOs
> is handed over to special board-dependent code.

there are plenty of SPI controllers which allow the CS to be manually
controlled. this isnt a "special" driver.

the MMC/SPI driver was written on a Blackfin system. it working on any other
system is coincidental as a result of leveraging the common frameworks. feel
free to submit fixes.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100129/3f571dfb/attachment.pgp