public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] ns16550: kick watchdog while waiting for a character
@ 2010-02-01 22:34 Ladislav Michl
  2010-02-03 21:47 ` Wolfgang Denk
  0 siblings, 1 reply; 2+ messages in thread
From: Ladislav Michl @ 2010-02-01 22:34 UTC (permalink / raw)
  To: u-boot

From: Ladislav Michl <ladis@linux-mips.org>

ns16550 busyloops waiting for incoming byte causing watchdog to reboot
while waiting for a key press. A call to WATCHDOG_RESET in NS16550_getc
loop fixes it.

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---

diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index 2fcc8c3..b3bf10b 100644
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -6,6 +6,7 @@
 
 #include <config.h>
 #include <ns16550.h>
+#include <watchdog.h>
 
 #define UART_LCRVAL UART_LCR_8N1		/* 8 data, 1 stop, no parity */
 #define UART_MCRVAL (UART_MCR_DTR | \
@@ -70,6 +71,7 @@ char NS16550_getc (NS16550_t com_port)
 		extern void usbtty_poll(void);
 		usbtty_poll();
 #endif
+		WATCHDOG_RESET();
 	}
 	return (com_port->rbr);
 }

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [PATCH] ns16550: kick watchdog while waiting for a character
  2010-02-01 22:34 [U-Boot] [PATCH] ns16550: kick watchdog while waiting for a character Ladislav Michl
@ 2010-02-03 21:47 ` Wolfgang Denk
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfgang Denk @ 2010-02-03 21:47 UTC (permalink / raw)
  To: u-boot

Dear Ladislav Michl,

In message <20100201223425.GA4294@localhost.localdomain> you wrote:
> From: Ladislav Michl <ladis@linux-mips.org>
> 
> ns16550 busyloops waiting for incoming byte causing watchdog to reboot
> while waiting for a key press. A call to WATCHDOG_RESET in NS16550_getc
> loop fixes it.
> 
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---

Applied, thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Don't you know anything? I should have thought anyone knows that  who
knows anything about anything...      - Terry Pratchett, _Soul Music_

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-03 21:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-01 22:34 [U-Boot] [PATCH] ns16550: kick watchdog while waiting for a character Ladislav Michl
2010-02-03 21:47 ` Wolfgang Denk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox