From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Sat, 06 Feb 2010 15:26:26 +0100 Subject: [U-Boot] [PATCH ARM 4/4] Change s3c24x0 register struct members to lower case In-Reply-To: <4B6D687F.2060606@fearnside-systems.co.uk> References: <4B3936EF.7030002@fearnside-systems.co.uk> <1f3430fb1002060418ydd28583sb6051dd1517fa864@mail.gmail.com> <4B6D687F.2060606@fearnside-systems.co.uk> Message-ID: <20100206142626.310A724F09@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear "kevin.morfitt at fearnside-systems.co.uk", In message <4B6D687F.2060606@fearnside-systems.co.uk> you wrote: > > The patches are split so that each patch makes only one type of change, > so there's only one thing that needs to be checked in each patch. > > - patches 1 and 2 only make white-space changes (the change was too big > so I had to split it into 2 patches) I think this should be merged into a single patch. > - patch 3 only makes code style changes such as moving external > function prototypes to header files, removing unused code, making line > lengths less than 81 characters, brackets around if/then/else/when/do > blocks, generally anything that checkpatch.pl warns about > - patch 4 changes the s3c24x0 register struct members to lower case > (which is the main aim of the patches) > > I can modify the patches to do all changes at the same time but when > I've done this before I've always been told that each patch should have > only one type of change in it, and I'm not sure if it would get NACK'ed > by someone else. Correct. Please keep the split as is. > What do you think - do you still want me to change the patch series? No, please leave as is. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de "We have the right to survive!" "Not be killing others." -- Deela and Kirk, "Wink of An Eye", stardate 5710.5