From: Matthias Kaehlcke <matthias@kaehlcke.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] edb93xx sdram: fix initialization
Date: Fri, 12 Feb 2010 10:23:58 +0100 [thread overview]
Message-ID: <20100212092358.GI15905@darwin> (raw)
In-Reply-To: <20100212070126.GA3406@morgana.gnudd.com>
El Fri, Feb 12, 2010 at 08:01:26AM +0100 Alessandro Rubini ha dit:
> > i gave my ack after a visual review of the patch, without having
> > tested it. i just installed a patched u-boot on one of my boards and
> > it doesn't boot :(
>
> Oh. The opposite of my board.
>
> Then, since I don't have a 9315A but only a similar one, it's better
> to drop the patch. I'll have a different sdram_cfg file for mine,
> then.
i'm pretty sure we'll be able to track this down, the purpose of your
patch is correct, i actually wonder why the current code works ...
if we can't solve the issue in the next days, you could still send a
patch which only writes the GlConfig register in
program_mode_registers(). this would fix at least on of the issues and
make your code less different from the one in the tree
--
Matthias Kaehlcke
Embedded Linux Developer
Barcelona
Comunicar bichos a <bug-coreutils@gnu.org>
(LANG=es_ES uname --help)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
next prev parent reply other threads:[~2010-02-12 9:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-11 20:46 [U-Boot] [PATCH 0/2] edb93xx: two patches for boot code Alessandro Rubini
2010-02-11 20:46 ` [U-Boot] [PATCH 1/2] ep93xx leds: remove arrays in data section Alessandro Rubini
2010-02-11 20:46 ` [U-Boot] [PATCH 2/2] edb93xx sdram: fix initialization Alessandro Rubini
2010-02-11 22:32 ` Matthias Kaehlcke
2010-02-12 7:01 ` Alessandro Rubini
2010-02-12 9:23 ` Matthias Kaehlcke [this message]
2010-02-12 17:24 ` Matthias Kaehlcke
2010-02-12 23:01 ` Alessandro Rubini
2010-02-16 19:24 ` Matthias Kaehlcke
2010-02-17 14:48 ` Alessandro Rubini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100212092358.GI15905@darwin \
--to=matthias@kaehlcke.net \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox