From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Fri, 12 Feb 2010 10:00:18 +0100 Subject: [U-Boot] [PATCH]: common/cmd_flash.c: bug-fix In-Reply-To: <1B4B728CB312483CB5A7BE72ECC00C67@smartbridges.com> References: <1B4B728CB312483CB5A7BE72ECC00C67@smartbridges.com> Message-ID: <201002121000.18952.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Friday 12 February 2010 09:31:17 Teh Kok How wrote: > --- u-boot-2009.11.1.orig/common/cmd_flash.c 2010-01-25 > 16:35:12.000000000 +0800 > > +++ u-boot-2009.11.1.new/common/cmd_flash.c 2010-02-12 > 16:18:10.565540182 +0800 > > @@ -43,6 +43,7 @@ > > > > #ifndef CONFIG_SYS_NO_FLASH > > extern flash_info_t flash_info[]; /* info for FLASH chips */ > > +extern struct mtd_device *current_mtd_dev; Sorry, but your patch has several problems: - What exactly are you trying to fix? Please add a small description on what's broken and how your patch fixes it. - Patch adds empty line after each line - Patch is line wrapped - Signed-off-by line missing Please see here for more details on creating and sending patches: http://www.denx.de/wiki/view/U-Boot/Patches Thanks. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de