From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Fri, 19 Feb 2010 08:57:18 +0100 Subject: [U-Boot] [PATCH 1/1] ppc4xx: add support for alternate format for ndfc In-Reply-To: <1266531913-20756-1-git-send-email-fkan@amcc.com> References: <1266531913-20756-1-git-send-email-fkan@amcc.com> Message-ID: <201002190857.18988.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Feng, On Thursday 18 February 2010 23:25:13 fkan at amcc.com wrote: > From: Feng Kan > > This is to lock down the ordering in the correction routine against > the calculate routine. Otherwise, incorrect define would cause ECC errors. It was my impression that we (finally) had done this ordering correct. The last changes were upon your request: 68e74567cf317318df52dbcb2ac170ffc5e7758a: ppc4xx: Fix ECC Correction bug with SMC ordering for NDFC driver I don't see how this patch should fix a potential problem. Please explain which problem exactly is fixed with this change. As Wolfgang already mentioned, CONFIG_MTD_NAND_ECC_SMC will not be set in this file. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de