From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 23 Feb 2010 16:24:12 +0100 Subject: [U-Boot] [PATCH v2] cmd_mtdparts.c: prevent printbuffer overflows In-Reply-To: <1266938310-32582-1-git-send-email-agust@denx.de> References: <1266938310-32582-1-git-send-email-agust@denx.de> Message-ID: <201002231624.12172.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Anatolij, On Tuesday 23 February 2010 16:18:30 Anatolij Gustschin wrote: > The length of configured MTDPARTS_DEFAULT string > could be greater than console printbuffer size. > Replace printf() by puts() to avoid potential buffer > overflows. > > Signed-off-by: Anatolij Gustschin > --- > Changes since v1: > - use puts() instead of printf() as suggested by Wolfgang. > > common/cmd_mtdparts.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/common/cmd_mtdparts.c b/common/cmd_mtdparts.c > index b375fea..0fd5ce2 100644 > --- a/common/cmd_mtdparts.c > +++ b/common/cmd_mtdparts.c > @@ -1254,8 +1254,9 @@ static void list_partitions(void) > printf("\ndefaults:\n"); > printf("mtdids : %s\n", > mtdids_default ? mtdids_default : "none"); > - printf("mtdparts: %s\n", > - mtdparts_default ? mtdparts_default : "none"); > + puts("mtdparts: "); > + puts(mtdparts_default ? mtdparts_default : "none"); > + puts("\n"); It might make sense to add a comment here, describing why you use these puts() calls instead of one printf(). Otherwise somebody else might trip into this problem again in a later time. Cheers, Stefan -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de