From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Kaehlcke Date: Sun, 28 Feb 2010 00:58:02 +0100 Subject: [U-Boot] [PATCH] ep93xx timer: Fix get_ticks() and usecs_to_ticks() In-Reply-To: <4B89ADA6.8020304@windriver.com> References: <20100226172637.GK3628@darwin> <4B89ADA6.8020304@windriver.com> Message-ID: <20100227235802.GD1667@darwin> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Tom, El Sat, Feb 27, 2010 at 05:41:26PM -0600 Tom ha dit: > Matthias Kaehlcke wrote: > >ep93xx timer: Make get_ticks() consistent with get_tbclk(), returning > >a value with CONFIG_SYS_HZ resolution. This fix obsoletes the function > >clk_to_systicks(), leading to a simplification of the timer code. Further > >a variable in usecs_to_ticks() is promoted to a 64-bit value, to avoid > >overflows of intermediate values. > > > >Signed-off-by: Matthias Kaehlcke > >Tested-by: Alessandro Rubini > > > Please rebase. > I applied the earlier version. it is based on the earlier version > I think these changes should be a much smaller patch. the patch without rebasing would have been shorter than the earlier one(s), that's why i proposed reverting the other one(s). making get_ticks() work with CONFIG_SYS_HZ resolution implied moving code around functions and removing code from others, resulting in a larger patch (but in resume in more compact and more readable code). best regards -- Matthias Kaehlcke Embedded Linux Developer Barcelona Comunicar bichos a (LANG=es_ES uname --help) .''`. using free software / Debian GNU/Linux | http://debian.org : :' : `. `'` gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-