[U-Boot] [PATCH] Add support for Indefia Nimbus Cloud Board

Wolfgang Denk
2010-01-25T22:34:02Z

Dear Semih Hazar,

In message <4B585314.7010100@indefia.com> you wrote:
> Nimbus Cloud is an AVR32 based single board computer with
> 256MiB NAND, 64MiB SDRAM, battery backed RTC, LCD/touch
> screen support, VGA Output, Ethernet and offers seamless
> integration with Indefia's Zigbee transceivers.
>
> ---
> CREDITS | 4 +
> MAINTAINERS | 4 +
> MAKEALL | 1 +
> Makefile | 3 +
> board/indefia/nimbuscloud/Makefile | 40 ++++++
> board/indefia/nimbuscloud/config.mk | 3 +
> board/indefia/nimbuscloud/flash.c | 226 +++++++++++++++++++++++++++++++
> board/indefia/nimbuscloud/nimbuscloud.c | 166 +++++++++++++++++++++++
> board/indefia/nimbuscloud/u-boot.lds | 72 ++++++++++
> include/configs/nimbuscloud.h | 182 +++++++++++++++++++++++++
> 10 files changed, 701 insertions(+), 0 deletions(-)

As explained before:

NAK for board/indefia/nimbuscloud/flash.c

> diff --git a/board/indefia/nimbuscloud/nimbuscloud.c b/board/indefia/nimbuscloud/nimbuscloud.c
> new file mode 100644
> index 0000000..03fc5c9
> --- /dev/null
> +++ b/board/indefia/nimbuscloud/nimbuscloud.c
...
> +#ifdef CONFIG_CMD_NET
> +
> +extern int macb_miiphy_read(char *devname, u8 phy_adr, u8 reg, u16 *value);
> +extern int macb_miiphy_write(char *devname, u8 phy_adr, u8 reg, u16 value);

Such prototypes belong into some header file.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Motto of the Electrical Engineer: Working computer hardware is a lot
like an erect penis: it stays up as long as you don't fuck with it.