[U-Boot] [PATCH] at91: Get rid of some warnings when building for otc570

[U-Boot] [PATCH] at91: Get rid of some warnings when building for otc570

[Matthias Fuchs]

The soft-i2c code for AT91 defines I2C_SOFT_DECLARATIONS
for direct access by dereferencing a pio pointer.
The OTC570 platform uses the AT91 gpio API so it does not
need the pio variable.

Signed-off-by: Matthias Fuchs <matthias.fuchs@esd.eu>
---
 include/configs/otc570.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/configs/otc570.h b/include/configs/otc570.h
index 8e27eba..4fde012 100644
--- a/include/configs/otc570.h
+++ b/include/configs/otc570.h
@@ -102,6 +102,7 @@
 	at91_set_pio_output(AT91_PIO_PORTB, 4, 0); \
 	at91_set_pio_output(AT91_PIO_PORTB, 5, 0); \
 }
+#define I2C_SOFT_DECLARATIONS
 /* Configure data pin as output */
 #define I2C_ACTIVE		at91_set_pio_output(AT91_PIO_PORTB, 4, 0)
 /* Configure data pin as input */
-- 
1.6.1

[U-Boot] [PATCH] at91: Get rid of some warnings when building for otc570

[Wolfgang Denk]

Dear Matthias Fuchs,

In message <201003241016.20459.matthias.fuchs@esd.eu> you wrote:
> The soft-i2c code for AT91 defines I2C_SOFT_DECLARATIONS
> for direct access by dereferencing a pio pointer.
> The OTC570 platform uses the AT91 gpio API so it does not
> need the pio variable.
> 
> Signed-off-by: Matthias Fuchs <matthias.fuchs@esd.eu>
> ---
>  include/configs/otc570.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)

Applied, thanks.

So this reduces the warnings to the (pretty common, on AT91):

atmel_dataflash_spi.c:25:2: warning: #warning Please update to use C structur SoC access !
atmel_usart.c:21:2: warning: #warning Please update to use C structur SoC access !
ohci-at91.c:30:2: warning: #warning Please update to use C structur SoC access !


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We are Microsoft. Unix is irrelevant. Openness is futile.  Prepare to
be assimilated.

[U-Boot] [PATCH] at91: Get rid of some warnings when building for otc570

[Matthias Fuchs]

> Dear Matthias Fuchs,
> 
> In message <201003241016.20459.matthias.fuchs@esd.eu> you wrote:
> > The soft-i2c code for AT91 defines I2C_SOFT_DECLARATIONS
> > for direct access by dereferencing a pio pointer.
> > The OTC570 platform uses the AT91 gpio API so it does not
> > need the pio variable.
> > 
> > Signed-off-by: Matthias Fuchs <matthias.fuchs@esd.eu>
> > ---
> >  include/configs/otc570.h |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> Applied, thanks.
> 
> So this reduces the warnings to the (pretty common, on AT91):
> 
> atmel_dataflash_spi.c:25:2: warning: #warning Please update to use C structur SoC access !
> atmel_usart.c:21:2: warning: #warning Please update to use C structur SoC access !
> ohci-at91.c:30:2: warning: #warning Please update to use C structur SoC access !
These are not fixable on-the-fly. As you might know there is a bigger work-in-progress
to switch the AT91 support completely towards c structs. I don't expect this to be done
before the outstanding release.

I am not sure if anyone is working on this right now. If so, please raise your finger!

Matthias