From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom
Date: Thu, 25 Mar 2010 13:38:17 -0400 [thread overview]
Message-ID: <201003251338.18817.vapier@gentoo.org> (raw)
In-Reply-To: <20100325094002.00014E731ED@gemini.denx.de>
On Thursday 25 March 2010 05:40:01 Wolfgang Denk wrote:
> Heiko wrote:
> > Ok, but this driver initialize in fec_probe() (which gets called
> > through fecmxc_initialize() on uboot startup) always the fec mac
> > address registers with eeprom mac address. So, if uboot not uses
>
> The question to me is why fec_probe() is called at all, even in cases
> where U-Boot does not use any network related commands. This is IMO
> wrong. Eventually somebody comes up with patches to fix this?
the current fec_mxc driver has squashed the initialize and probe steps. it
should have half the things removed from probe and put into initialize and
then the call to probe moved to the init step.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100325/eafcb2b9/attachment.pgp
next prev parent reply other threads:[~2010-03-25 17:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-24 11:56 [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom Heiko Schocher
2010-03-24 12:35 ` Stefano Babic
2010-03-24 12:52 ` Detlev Zundel
2010-03-24 20:39 ` Mike Frysinger
2010-03-24 13:07 ` Heiko Schocher
2010-03-24 20:35 ` Mike Frysinger
2010-03-25 6:31 ` Heiko Schocher
2010-03-25 9:40 ` Wolfgang Denk
2010-03-25 13:16 ` Detlev Zundel
2010-03-25 14:02 ` Wolfgang Denk
2010-03-26 8:39 ` [U-Boot] Design principles (was: Re: [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom) Detlev Zundel
2010-03-26 10:40 ` Wolfgang Denk
2010-03-26 11:47 ` [U-Boot] Design principles Detlev Zundel
2010-03-26 12:38 ` Wolfgang Denk
2010-03-26 13:02 ` Detlev Zundel
2010-03-26 18:21 ` Wolfgang Denk
2010-03-27 7:32 ` Heiko Schocher
2010-03-27 10:21 ` Wolfgang Denk
2010-03-25 17:49 ` [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom Mike Frysinger
2010-03-25 17:38 ` Mike Frysinger [this message]
2010-03-25 19:11 ` Wolfgang Denk
2010-03-25 19:22 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003251338.18817.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox