From: Mike Frysinger <vapier@gentoo.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] net, fec_mxc: init mac address before using network commands
Date: Tue, 30 Mar 2010 03:33:14 -0400 [thread overview]
Message-ID: <201003300333.15791.vapier@gentoo.org> (raw)
In-Reply-To: <4BB18E59.5000004@denx.de>
On Tuesday 30 March 2010 01:38:33 Heiko Schocher wrote:
> initialize mac address with the value from "ethaddr", before
> doing some network commands. This is not in line with u-boot
> design principle "not to initalize not used devices", and
> maybe should go away, if there is a solution for passing
> the mac address to arm linux kernels.
NACK like i already said -- net drivers should only ever be reading
eth_driver->enetaddr. they should never touch the environment as the common
net code takes care of this.
i would instead fix the fec_probe() to stop writing "ethaddr" since it already
writes to eth_driver->enetaddr.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100330/4a1a6523/attachment.pgp
next prev parent reply other threads:[~2010-03-30 7:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 5:38 [U-Boot] net, fec_mxc: init mac address before using network commands Heiko Schocher
2010-03-30 7:33 ` Mike Frysinger [this message]
2010-03-30 7:49 ` Wolfgang Denk
2010-03-30 7:53 ` Detlev Zundel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201003300333.15791.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox