From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [v3] fix print_size printing fractional gigabyte numbers on 32-bit platforms
Date: Fri, 09 Apr 2010 22:10:00 +0200 [thread overview]
Message-ID: <20100409201000.2ED3E19F36@gemini.denx.de> (raw)
In-Reply-To: <1269990179-23666-1-git-send-email-timur@freescale.com>
Dear Timur Tabi,
In message <1269990179-23666-1-git-send-email-timur@freescale.com> you wrote:
> In print_size(), the math that calculates the fractional remainder of a number
> used the same integer size as a physical address. However, the "10 *" factor
> of the algorithm means that a large number (e.g. 1.5GB) can overflow the
> integer if we're running on a 32-bit system. Therefore, we need to
> disassociate this function from the size of a physical address.
>
> Signed-off-by: Timur Tabi <timur@freescale.com>
> ---
> lib_generic/display_options.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The reasonable man adapts himself to the world; the unreasonable one
persists in trying to adapt the world to himself. Therefore all
progress depends on the unreasonable man." - George Bernard Shaw
next prev parent reply other threads:[~2010-04-09 20:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-30 23:02 [U-Boot] [PATCH] [v3] fix print_size printing fractional gigabyte numbers on 32-bit platforms Timur Tabi
2010-03-30 23:02 ` [U-Boot] [PATCH] allow print_size to print large numbers on 32-bit systems Timur Tabi
2010-04-09 20:22 ` Wolfgang Denk
2010-04-09 20:27 ` Timur Tabi
2010-04-09 20:40 ` Wolfgang Denk
2010-04-12 16:12 ` Timur Tabi
2010-04-12 16:16 ` Nick Thompson
2010-04-12 16:21 ` Timur Tabi
2010-04-12 16:27 ` Nick Thompson
2010-04-12 18:02 ` Wolfgang Denk
2010-04-12 17:59 ` Wolfgang Denk
2010-04-12 18:03 ` Timur Tabi
2010-04-12 18:20 ` Wolfgang Denk
2010-04-12 18:22 ` Scott Wood
2010-04-12 18:30 ` Timur Tabi
2010-04-12 18:50 ` Wolfgang Denk
2010-04-12 19:10 ` Timur Tabi
2010-04-12 19:26 ` Scott Wood
2010-04-09 20:10 ` Wolfgang Denk [this message]
2010-04-12 16:04 ` [U-Boot] [PATCH] [v3] fix print_size printing fractional gigabyte numbers on 32-bit platforms Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100409201000.2ED3E19F36@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox