From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 3/3] mpc5121: pdm360ng: add coprocessor POST
Date: Thu, 15 Apr 2010 11:25:20 +0200 [thread overview]
Message-ID: <20100415112520.3b6c341d@wker> (raw)
In-Reply-To: <m2bpdlf50q.fsf@ohwell.denx.de>
Hi Detlev,
On Thu, 15 Apr 2010 11:18:13 +0200
Detlev Zundel <dzu@denx.de> wrote:
...
> >> @@ -286,6 +287,18 @@ struct post_test post_list[] =
> >> #if CONFIG_POST & CONFIG_SYS_POST_BSPEC5
> >> CONFIG_POST_BSPEC5,
> >> #endif
> >> +#if CONFIG_POST & CONFIG_SYS_POST_COPROC
> >> + {
> >> + "Coprocessors communication test",
> >> + "coproc_com",
> >> + "This test checks communication with coprocessors.",
> >> + POST_RAM | POST_ALWAYS | POST_CRITICAL,
> >> + &pdm360ng_coprocessor_post_test,
> >> + NULL,
> >> + NULL,
> >> + CONFIG_SYS_POST_COPROC
> >> + }
> >> +#endif
> >> };
> >
> > I don't want to see board specific code (pdm360ng_*) in such a global
> > file. Please use a more generic approach.
>
> Do you mean like for example CONFIG_POST_BSPEC1 used for lwmon5?
>
> Anatolij, this should be straight forward.
Similar was in the first patch version. But according to Wolfgang
this doesn't belong in the board config file.
Anatolij
next prev parent reply other threads:[~2010-04-15 9:25 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-16 16:10 [U-Boot] [PATCH v2 0/7] Add support for PDM360NG board Anatolij Gustschin
2010-03-16 16:10 ` [U-Boot] [PATCH v2 1/7] mpc512x: make MEM IO Control configuration a board config option Anatolij Gustschin
2010-03-16 16:10 ` [U-Boot] [PATCH v2 2/7] mpc512x: add multi serial PSC support Anatolij Gustschin
2010-03-16 16:10 ` [U-Boot] [PATCH v2 3/7] mpc5121: add PSC serial communication routines Anatolij Gustschin
2010-03-16 16:10 ` [U-Boot] [PATCH v2 4/7] fdt_support: add partitions fixup in mtd node Anatolij Gustschin
2010-03-16 16:10 ` [U-Boot] [PATCH v2 5/7] mpc5121: add common post_word_load/store code Anatolij Gustschin
2010-03-16 16:10 ` [U-Boot] [PATCH v2 6/7] mpc5121: add support for PDM360NG board Anatolij Gustschin
2010-03-16 16:10 ` [U-Boot] [PATCH v2 7/7] mpc5121: cpu/mpc512x/diu.c: fix warnings Anatolij Gustschin
2010-03-21 19:24 ` Wolfgang Denk
2010-03-21 19:23 ` [U-Boot] [PATCH v2 6/7] mpc5121: add support for PDM360NG board Wolfgang Denk
2010-04-14 10:39 ` Anatolij Gustschin
2010-04-14 14:21 ` [U-Boot] [PATCH v3 0/3] Add " Anatolij Gustschin
2010-04-14 14:21 ` [U-Boot] [PATCH v3 1/3] mpc5121: determine RAM size using get_ram_size() Anatolij Gustschin
2010-04-14 14:21 ` [U-Boot] [PATCH v3 2/3] mpc5121: add support for PDM360NG board Anatolij Gustschin
2010-04-14 14:21 ` [U-Boot] [PATCH v3 3/3] mpc5121: pdm360ng: add coprocessor POST Anatolij Gustschin
2010-04-14 15:40 ` Wolfgang Denk
2010-04-15 9:18 ` Detlev Zundel
2010-04-15 9:25 ` Anatolij Gustschin [this message]
2010-04-15 11:48 ` Wolfgang Denk
2010-04-15 11:46 ` Wolfgang Denk
2010-04-15 10:24 ` Anatolij Gustschin
2010-04-15 11:54 ` Wolfgang Denk
2010-04-14 15:48 ` [U-Boot] [PATCH v3 2/3] mpc5121: add support for PDM360NG board Wolfgang Denk
2010-04-15 12:32 ` Anatolij Gustschin
2010-04-15 12:43 ` Stefan Roese
2010-04-15 15:18 ` Wolfgang Denk
2010-04-14 15:31 ` [U-Boot] [PATCH v3 1/3] mpc5121: determine RAM size using get_ram_size() Wolfgang Denk
2010-04-15 12:20 ` Anatolij Gustschin
2010-03-21 19:09 ` [U-Boot] [PATCH v2 5/7] mpc5121: add common post_word_load/store code Wolfgang Denk
2010-03-21 19:08 ` [U-Boot] [PATCH v2 4/7] fdt_support: add partitions fixup in mtd node Wolfgang Denk
2010-03-21 19:05 ` [U-Boot] [PATCH v2 3/7] mpc5121: add PSC serial communication routines Wolfgang Denk
2010-03-21 19:04 ` [U-Boot] [PATCH v2 2/7] mpc512x: add multi serial PSC support Wolfgang Denk
2010-03-21 19:03 ` [U-Boot] [PATCH v2 1/7] mpc512x: make MEM IO Control configuration a board config option Wolfgang Denk
2010-03-21 19:00 ` [U-Boot] [PATCH v2 0/7] Add support for PDM360NG board Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100415112520.3b6c341d@wker \
--to=agust@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox