[U-Boot] [PATCH v3 3/3] mpc5121: pdm360ng: add coprocessor POST

Wolfgang Denk
2010-04-15T11:54:27Z

Dear Anatolij Gustschin,

In message <20100415122416.050f31a8@wker> you wrote:
>
> What would be a preferred way to realize this? Defining a weak
> function in post/post.c or post/tests.c which could be over-ridden
> by board specific one? Like:

This would eventually indeed allow for cleaner code, but then we
should also clean up the existing lwmon5 and sysmon1 code in the same
way. I don't want to urge you doing that, though.

For now I would also accept the code as is, just with a more generic
function name.

> Then I have to put board specific post code in board/pdm360ng/post.c
> to the pdm360ng.c file back. Otherwise the board's
> coprocessor_post_test() function is not linked if there is no other
> code in this post.c file which is strongly-linked.

Actually board specific POST code should go to post/board/pdm360ng/

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Backed up the system lately?