[U-Boot] [PATCH v3 3/3] mpc5121: pdm360ng: add coprocessor POST

Anatolij Gustschin
2010-04-15T09:25:20Z

Hi Detlev,

On Thu, 15 Apr 2010 11:18:13 +0200
Detlev Zundel <dzu@denx.de> wrote:

...
> >> @@ -286,6 +287,18 @@ struct post_test post_list[] =
> >> #if CONFIG_POST & CONFIG_SYS_POST_BSPEC5
> >> CONFIG_POST_BSPEC5,
> >> #endif
> >> +#if CONFIG_POST & CONFIG_SYS_POST_COPROC
> >> + {
> >> + "Coprocessors communication test",
> >> + "coproc_com",
> >> + "This test checks communication with coprocessors.",
> >> + POST_RAM | POST_ALWAYS | POST_CRITICAL,
> >> + &pdm360ng_coprocessor_post_test,
> >> + NULL,
> >> + NULL,
> >> + CONFIG_SYS_POST_COPROC
> >> + }
> >> +#endif
> >> };
> >
> > I don't want to see board specific code (pdm360ng_*) in such a global
> > file. Please use a more generic approach.
>
> Do you mean like for example CONFIG_POST_BSPEC1 used for lwmon5?
>
> Anatolij, this should be straight forward.

Similar was in the first patch version. But according to Wolfgang
this doesn't belong in the board config file.

Anatolij