[U-Boot] [PATCH v3 3/3] mpc5121: pdm360ng: add coprocessor POST

Wolfgang Denk
2010-04-14T15:40:16Z

Dear Anatolij Gustschin,

In message <1271254909-20398-4-git-send-email-agust@denx.de> you wrote:
> Adds coprocessor communication POST code.
>
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> ---
> board/pdm360ng/Makefile | 1 +
> board/pdm360ng/post.c | 75 ++++++++++++++++++++++++++++++++++++++++++++
> include/configs/pdm360ng.h | 5 +++
> include/post.h | 1 +
> post/tests.c | 13 +++++++
> 5 files changed, 95 insertions(+), 0 deletions(-)
> create mode 100644 board/pdm360ng/post.c
...
> --- a/post/tests.c
> +++ b/post/tests.c
> @@ -53,6 +53,7 @@ extern int gdc_post_test (int flags);
> extern int fpga_post_test (int flags);
> extern int lwmon5_watchdog_post_test(int flags);
> extern int sysmon1_post_test(int flags);
> +extern int pdm360ng_coprocessor_post_test(int flags);
>
> extern int sysmon_init_f (void);
>
> @@ -286,6 +287,18 @@ struct post_test post_list[] =
> #if CONFIG_POST & CONFIG_SYS_POST_BSPEC5
> CONFIG_POST_BSPEC5,
> #endif
> +#if CONFIG_POST & CONFIG_SYS_POST_COPROC
> + {
> + "Coprocessors communication test",
> + "coproc_com",
> + "This test checks communication with coprocessors.",
> + POST_RAM | POST_ALWAYS | POST_CRITICAL,
> + &pdm360ng_coprocessor_post_test,
> + NULL,
> + NULL,
> + CONFIG_SYS_POST_COPROC
> + }
> +#endif
> };

I don't want to see board specific code (pdm360ng_*) in such a global
file. Please use a more generic approach.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
When a program is being tested, it is too late to make design
changes. -- Geoffrey James, "The Tao of Programming"