public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC] PPC: post_word_{load/store} - eliminate redundant code
Date: Tue, 20 Apr 2010 23:39:09 +0200	[thread overview]
Message-ID: <20100420213909.7FE50E22AD9@gemini.denx.de> (raw)
In-Reply-To: <v2t660c0f821004190944p4a0a060fha1c92dbede09a7bf@mail.gmail.com>

Dear Michael Zaidman,

In message <v2t660c0f821004190944p4a0a060fha1c92dbede09a7bf@mail.gmail.com> you wrote:
> 
> In order to eliminate redundant code for powerPC architecture when
> defining post_word_{load/store} routines I suggest  moving them into
> the arch/ppc/lib/commproc.c file rather than adding them to every
> arch/ppc/cpu/XXXX.

NAK. The commproc.* files are supposed to contain code dealing with
the PowerQUICC Communication Processor Modules. This is in no way the
right place for common code.

Stefan - arch/ppc/cpu/ppc4xx/commproc.c  makes no sense - can we
please clean this up?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The people of Gideon have always believed that life is  sacred.  That
the  love  of  life  is  the  greatest  gift  ... We are incapable of
destroying or interfering with the creation of that which we love  so
deeply -- life in every form from fetus to developed being.
	-- Hodin of Gideon, "The Mark of Gideon", stardate 5423.4

  parent reply	other threads:[~2010-04-20 21:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-19 16:44 [U-Boot] [RFC] PPC: post_word_{load/store} - eliminate redundant code Michael Zaidman
2010-04-20 19:55 ` Michael Zaidman
2010-04-20 21:39 ` Wolfgang Denk [this message]
2010-04-21  4:30   ` Stefan Roese
2010-04-21  7:05   ` Michael Zaidman
2010-04-21 13:24   ` Michael Zaidman
2010-04-21 13:51     ` Stefan Roese
2010-04-21 14:07       ` Michael Zaidman
2010-04-21 13:59     ` Wolfgang Denk
2010-04-21 14:29       ` Michael Zaidman
2010-04-21 21:40         ` Wolfgang Denk
2010-04-22  0:16           ` Mike Frysinger
2010-04-22  6:41           ` Michael Zaidman
2010-04-22  9:03             ` Wolfgang Denk
2010-04-22  9:27               ` Michael Zaidman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100420213909.7FE50E22AD9@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox