From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Wed, 21 Apr 2010 06:30:27 +0200
Subject: [U-Boot] [RFC] PPC: post_word_{load/store} - eliminate
	redundant code
In-Reply-To: <20100420213909.7FE50E22AD9@gemini.denx.de>
References: <v2t660c0f821004190944p4a0a060fha1c92dbede09a7bf@mail.gmail.com>
	<20100420213909.7FE50E22AD9@gemini.denx.de>
Message-ID: <201004210630.27720.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Wolfgang,

On Tuesday 20 April 2010 23:39:09 Wolfgang Denk wrote:
> > In order to eliminate redundant code for powerPC architecture when
> > defining post_word_{load/store} routines I suggest  moving them into
> > the arch/ppc/lib/commproc.c file rather than adding them to every
> > arch/ppc/cpu/XXXX.
> 
> NAK. The commproc.* files are supposed to contain code dealing with
> the PowerQUICC Communication Processor Modules. This is in no way the
> right place for common code.
> 
> Stefan - arch/ppc/cpu/ppc4xx/commproc.c  makes no sense - can we
> please clean this up?

Yes, I'll take a look at it.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de