From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Tue, 27 Apr 2010 16:11:20 +0200
Subject: [U-Boot] [PATCH] powerpc: Consolidate bootcount_{store|load}
	for PowerPC
In-Reply-To: <m2fx2hngew.fsf@ohwell.denx.de>
References: <1272292133-1843-1-git-send-email-sr@denx.de>
	<m2fx2hngew.fsf@ohwell.denx.de>
Message-ID: <201004271611.20981.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Detlev,

On Tuesday 27 April 2010 16:01:11 Detlev Zundel wrote:
> > This patch consolidates bootcount_{store|load} for PowerPC by
> > implementing a common version in arch/powerpc/lib/bootcount.c. This
> > code is now used by all PowerPC variants that currently have these
> > functions implemented.
> > 
> > The functions now use the proper IO-accessor functions to read/write the
> > values.
> > 
> > This code also supports two different bootcount versions:
> > 
> > a) Use 2 seperate words (2 * 32bit) to store the bootcounter
> > b) Use only 1 word (2* 16bit) to store the bootcounter
> > 
> > Version b) was already used by MPC5xxx.
> > 
> > Signed-off-by: Stefan Roese <sr@denx.de>
> > Cc: Michael Zaidman <michael.zaidman@gmail.com>
> > Cc: Wolfgang Denk <wd@denx.de>
> > Cc: Kim Phillips <kim.phillips@freescale.com>
> > Cc: Anatolij Gustschin <agust@denx.de>
> 
> Cool, thanks!
> 
> I have only a cosmetic suggestion - can we rename the option
> CONFIG_SYS_BOOTCOUNT_USE_32BIT to CONFIG_SYS_BOOTCOUNT_SINGLEWORD?
> According to your documentation this would describe the situation
> somewhat closer.

Right. This name is better. I'll send an updated patch soon.
 
> Apart from that:
> 
> Acked-by: Detlev Zundel <dzu@denx.de>

Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de