public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] mtdparts: fix write through NULL pointer
Date: Wed, 28 Apr 2010 13:30:23 +0200	[thread overview]
Message-ID: <201004281330.23510.sr@denx.de> (raw)
In-Reply-To: <4BD81816.2050601@denx.de>

Hi Stefano,

On Wednesday 28 April 2010 13:12:22 Stefano Babic wrote:
> > The "mtdparts add" command wrote through a NULL pointer - on many
> > systems this went unnoticed (PowerPC has writable RAM there, some ARM
> > systems have ROM where a write has no effect), but on arm1136
> > (i.MX31) it crashed the system.
> > 
> > Add appropriate checks.
> 
> Hi Wolfgang,
> 
> I have already sent a patch fixing this issue,
> 
> http://lists.denx.de/pipermail/u-boot/2010-April/070347.html
> 
> However, I preferred (easier way) to fix the calling function as the
> device_parse(). I do not know if Stefan has already merged it.

No, I haven't merged it. Since I was not sure if this has to go through one of 
my git repositories. Both cfi-flash and ubi don't really include this mtdparts 
stuff.

Wolfgang, I suggest you apply your preferred version directly.

Thanks.

Cheers,
Stefan

--
DENX Software Engineering GmbH,      MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich,  Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

  reply	other threads:[~2010-04-28 11:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-28  9:00 [U-Boot] [PATCH 1/2] mtdparts: fix write through NULL pointer Wolfgang Denk
2010-04-28  9:00 ` [U-Boot] [PATCH 2/2] mtdparts: get rid of custom DEBUG macro, use debug() Wolfgang Denk
2010-04-28 11:12 ` [U-Boot] [PATCH 1/2] mtdparts: fix write through NULL pointer Stefano Babic
2010-04-28 11:30   ` Stefan Roese [this message]
2010-04-30 22:39   ` Wolfgang Denk
2010-05-01 11:49     ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201004281330.23510.sr@denx.de \
    --to=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox