public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Anatolij Gustschin <agust@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] video: add support for display controller in MB86R0x SoCs
Date: Sat, 1 May 2010 20:51:33 +0200	[thread overview]
Message-ID: <20100501205133.6776f306@wker> (raw)
In-Reply-To: <4BD0493B.2090706@arcor.de>

Dear Matthias,

On Thu, 22 Apr 2010 15:03:55 +0200
Matthias Wei?er <weisserm@arcor.de> wrote:
...
> >> +/*
> >> + * Set a RGB color in the LUT
> >> + */
> >> +void video_set_lut(unsigned int index, unsigned char r,
> >> +					unsigned char g, unsigned char b)
> >> +{
> >> +
> >> +}
> >
> > Code seems to be missing?
> 
> The driver doesn't support palletized color format at the moment but 
> removing this function leads to a linker error.
> 
> Maybe we should add a config option to disable palletized color format 
> or add a weak function somewhere. Maybe Anatolij can comment on this 
> issue also.

I will send a patch adding weak default video_set_lut() to cfb_console
driver. You can remove empty function then.

Best regards,
Anatolij

  reply	other threads:[~2010-05-01 18:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-22 10:30 [U-Boot] [PATCH 0/3] Add support for MB86R0x SoCs Matthias Weisser
2010-04-22 10:30 ` [U-Boot] [PATCH 1/3] arm: " Matthias Weisser
2010-04-22 10:30   ` [U-Boot] [PATCH 2/3] video: add support for display controller in " Matthias Weisser
2010-04-22 10:30     ` [U-Boot] [PATCH 3/3] arm: Add support for jadecpu board based on MB86R01 SoC Matthias Weisser
2010-04-22 12:51       ` Wolfgang Denk
2010-04-22 13:17         ` Matthias Weißer
2010-04-22 14:13           ` Wolfgang Denk
2010-05-03 11:38         ` Matthias Weißer
2010-05-03 12:28           ` Wolfgang Denk
2010-04-22 12:41     ` [U-Boot] [PATCH 2/3] video: add support for display controller in MB86R0x SoCs Wolfgang Denk
2010-04-22 13:03       ` Matthias Weißer
2010-05-01 18:51         ` Anatolij Gustschin [this message]
2010-05-01 19:05         ` [U-Boot] [PATCH] video: cfb_console: add weak default video_set_lut() Anatolij Gustschin
2010-06-12  8:20           ` [U-Boot] [PATCH v2] " Anatolij Gustschin
2010-06-12  8:35             ` Anatolij Gustschin
2010-04-28  6:29       ` [U-Boot] [PATCH 2/3] video: add support for display controller in MB86R0x SoCs Matthias Weißer
2010-04-28  6:44         ` Wolfgang Denk
2010-04-28  8:08           ` Matthias Weißer
2010-05-01 18:46     ` Anatolij Gustschin
2010-04-22 12:34   ` [U-Boot] [PATCH 1/3] arm: Add support for " Wolfgang Denk
2010-04-26  6:55     ` Matthias Weißer
2010-05-04 22:18       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100501205133.6776f306@wker \
    --to=agust@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox