public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Kim Phillips <kim.phillips@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] remove main CHANGELOG file
Date: Wed, 5 May 2010 16:06:07 -0500	[thread overview]
Message-ID: <20100505160607.99edd83d.kim.phillips@freescale.com> (raw)
In-Reply-To: <20100505065401.04FACB076D3@gemini.denx.de>

On Wed, 5 May 2010 08:54:01 +0200
Wolfgang Denk <wd@denx.de> wrote:

> Dear Kim Phillips,
> 
> In message <20100504192544.6506945d.kim.phillips@freescale.com> you wrote:
> >
> > > > It is assumed that this file's only purpose is to serve non-git users
> > > > downloading u-boot project source in the form of a tarball release.  If
> > > > that is the case, then the generation of the CHANGELOG file should occur
> > > > at tarball release generation time, and not consume duplicate history,
> 
> Can you recommend a way how such auto-generation / inclusion would be
> done?
> 
> Currently I'm using something like this:
> 
> 	$ V=2010.03
> 	$ PREFIX=u-boot-${V}
> 	$ git archive --format=tar --prefix=${PREFIX}/ v${V} | \
> 	> bzip2 -v9 >~/tmp/${PREFIX}.tar.bz2
> 
> How could this be made to include a non-git-controlled CHANGELOG?

(see below)

> > > Slowing things down? C'me on.
> > 
> > maybe not git grep performance-wise (yet), but on a
> > frequently-occurring search term, when we have to visually sift through
> > and page down through a large number of CHANGELOG hits (that invariably
> > show up first), then yes, I consider that a development-time barrier.
> 
> So what about git performance? A "grep foobar CHANGELOG" is
> significantly faster than a "git log --grep=foobar", isn't it?

true, but I find that git log runs well after it is run once and
everything is loaded in the cache.

Also, if I'm git grepping in the u-boot git tree, I want to grep
the source, not the git log.

> > > NAK. My position about these files has not changed.
> > 
> > Please reconsider: u-boot has no need to be 'special' in this area, and
> > this file's continued existence is a lingering harassment for
> > developers such as myself.
> 
> Harassment? Strong words. I am seriously listening to your arguments,
> but so far I feel that there is a lot of emotion in your message but
> only few arguments I can follow.

you are right; bad choice of words; I meant something milder - more
along the lines of 'annoyance'.

> In addition to the arguments already mentioned here is another reason
> why I would like to keep this file in place: Quite often we have to
> work with copies of the U-Boot source tree that do not contain any
> good information about which version they might have been derived
> from; the CHANGELOG at least gives an idea about the time frame.
> 
> How would you try such identification?

it appears that the granularity of CHANGELOG updates is equal to that
of VERSION, PATCHLEVEL, and EXTRAVERSION assignments in the root
Makefile; so presumably one can refer to those instead.

For exact per-export granularity, one can do something like this:

cd u-boot
echo '$Format:%H$' > snapshot.commit
git add snapshot.commit && git commit -m 'add snapshot.commit file'
echo 'snapshot.commit' > .git/info/attributes
git archive --format=tar --prefix=${PREFIX}/ <commit> ...

...the resultant tarball's snapshot.commit file will contain the value
of the sha id representing commit <commit>.

for more info, see the gitattributes manpage and the list of
placeholders in the PRETTY FORMATS section of the git log manpage.

Kim

  parent reply	other threads:[~2010-05-05 21:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-14  2:16 [U-Boot] [PATCH 2/2] remove main CHANGELOG file Kim Phillips
2010-05-04 21:41 ` Wolfgang Denk
2010-05-05  0:25   ` Kim Phillips
2010-05-05  6:54     ` Wolfgang Denk
2010-05-05 13:51       ` Marek Vasut
2010-05-05 14:17         ` Wolfgang Denk
2010-05-05 14:56           ` Timur Tabi
2010-05-05 15:07             ` Wolfgang Denk
2010-05-05 16:03               ` Peter Tyser
2010-05-05 19:05                 ` Wolfgang Denk
2010-05-05 19:45                   ` Scott Wood
2010-05-05 20:36                     ` Wolfgang Denk
2010-05-05 20:37                   ` Peter Tyser
2010-05-05 20:58                     ` Wolfgang Denk
2010-05-05 21:43                       ` Peter Tyser
2010-05-05 21:51                         ` Wolfgang Denk
2010-07-16 18:44                           ` Kim Phillips
2010-05-05 21:06       ` Kim Phillips [this message]
2010-05-05 21:07         ` Wolfgang Denk
2010-05-05 21:09         ` Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100505160607.99edd83d.kim.phillips@freescale.com \
    --to=kim.phillips@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox