public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] remove main CHANGELOG file
Date: Wed, 05 May 2010 21:05:41 +0200	[thread overview]
Message-ID: <20100505190541.BFEFCB0FF8E@gemini.denx.de> (raw)
In-Reply-To: <1273075406.2451.4225.camel@localhost.localdomain>

Dear Peter Tyser,

In message <1273075406.2451.4225.camel@localhost.localdomain> you wrote:
> 
> Could you describe what you use CHANGELOG for?  I often look at logs,
> but 99% of the time its a log of a specific file or directory to trace a
> bug, see why feature X was added, etc.  I rarely look at the
> repositories entire log, and if I do, I use 'git log'.  Although 'git
> log' takes longer, its guaranteed to be accurate, unlike CHANGELOG which
> may be slightly out of date.

Most frequently I use it in combination with some form of grep command
(grep, agrep etc.); sometimes I use it in vi/view for manual searching
/ reading.

Here are a few reasons where I prefer accessing the CHANGELOG over
running "git log --grep":

1) it's faster:

	-> time grep foobar CHANGELOG

	real    0m0.005s
	user    0m0.004s
	sys 0m0.001s

	-> time git log --grep=foobar >/dev/null

	real    0m0.240s
	user    0m0.219s
	sys 0m0.021s

2) it's more efficient:

	-> strace -f grep foobar CHANGELOG 2>&1 >/dev/null | wc -l
	143
	-> strace -f git log --grep=foobar 2>&1 >/dev/null | wc -l
	2494

3) it delivers only the lines I cactually search for, while "git log
   --grep" always spills out the whole commit message:

	-> grep MPC512x CHANGELOG | wc -l
	24
	-> git log --grep=MPC512x | wc -l
	272

4) I can use arbitrary grep options.  I am not aware of a git
   equivalent to, say:

   	-> grep -C2 --color string CHANGELOG

5) I can use other tools to process the messages, like agrep for fuzzy
   searching; I frequently use this when checking if a specific patch
   has been applied - too many times a plain text search does not work
   because the committer manually edited the commit message to fix
   typos etc.  I am not aware of a git equivalent to, say:

   	-> agrep -2 -i string CHANGELOG

   This is probably my most frequently used command


> If you do prefer the speed of looking at a CHANGELOG file, its easy to
> generate one when you require it.

Yes, I know. But I also want it available to those who don't use git,
so it should to be included in the release tarball, and in the
auto-generated tarballs when using the "snapshot" links on the web
interface; for example try:

	-> wget -O u-boot.tgz 'http://git.denx.de/?p=u-boot.git;a=snapshot;sf=tgz'

> > Does it hurt you?
> 
> 'hurt' is a strong word, but it certainly annoys me too.  Eg:
> - Every time someone greps they have to visually ignore the CHANGELOG
> file hits, or alternately make a grep wrapper script specific to u-boot
> that strips out CHANGELOG hits.

Strange. If I ever run into such a problem then so infrequently that
I don't notice it. I guess this is because I usually only grep in
specific file types (like "*.[Sch]" or so).

> - Its a duplication of data that's already stored in the repository
> history.  Who likes duplicated data?

In the strict sense, all the checked out files are duplicated data.

> - For any change that is automated via a script/grep/sed/etc one needs
> to filter out the CHANGELOG files.

You probably need to exclude a number of other files as well?

> We could also follow Linux's lead and upload the CHANGELOG as a separate
> file from the source.  eg there would be a CHANGELOG-{V} for each
> released U-Boot version detailing only what changed since the last
> release (www.kernel.org/pub/linux/kernel/v2.6/), or alternatively one
> mega-CHANGELOG like we're doing now if people prefer.

I would like to keep the CHANGELOG as part of tarballs, including 
auto-generated ones.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Speculation is always more interesting than facts.
                                    - Terry Pratchett, _Making_Money_

  reply	other threads:[~2010-05-05 19:05 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-14  2:16 [U-Boot] [PATCH 2/2] remove main CHANGELOG file Kim Phillips
2010-05-04 21:41 ` Wolfgang Denk
2010-05-05  0:25   ` Kim Phillips
2010-05-05  6:54     ` Wolfgang Denk
2010-05-05 13:51       ` Marek Vasut
2010-05-05 14:17         ` Wolfgang Denk
2010-05-05 14:56           ` Timur Tabi
2010-05-05 15:07             ` Wolfgang Denk
2010-05-05 16:03               ` Peter Tyser
2010-05-05 19:05                 ` Wolfgang Denk [this message]
2010-05-05 19:45                   ` Scott Wood
2010-05-05 20:36                     ` Wolfgang Denk
2010-05-05 20:37                   ` Peter Tyser
2010-05-05 20:58                     ` Wolfgang Denk
2010-05-05 21:43                       ` Peter Tyser
2010-05-05 21:51                         ` Wolfgang Denk
2010-07-16 18:44                           ` Kim Phillips
2010-05-05 21:06       ` Kim Phillips
2010-05-05 21:07         ` Wolfgang Denk
2010-05-05 21:09         ` Kim Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100505190541.BFEFCB0FF8E@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox