From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Mon, 10 May 2010 12:41:46 +0200 Subject: [U-Boot] [PATCH v4 6/8] mpc5121: add support for PDM360NG board In-Reply-To: References: <20100423095621.2D27D1A09F@gemini.denx.de> <1272130031-26230-1-git-send-email-agust@denx.de> <1272130031-26230-2-git-send-email-agust@denx.de> <1272130031-26230-3-git-send-email-agust@denx.de> <1272130031-26230-4-git-send-email-agust@denx.de> <1272130031-26230-5-git-send-email-agust@denx.de> <1272130031-26230-6-git-send-email-agust@denx.de> <1272130031-26230-7-git-send-email-agust@denx.de> Message-ID: <20100510124146.17d88196@wker> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Sun, 9 May 2010 11:01:45 +0300 Michael Zaidman wrote: > On Sat, Apr 24, 2010 at 8:27 PM, Anatolij Gustschin wrote: > > PDM360NG is a MPC5121E based board by ifm ecomatic gmbh. > > > > [snip] > > +#define CONFIG_SYS_INIT_RAM_END CONFIG_SYS_SRAM_SIZE > /* End of area */ > + > +#define CONFIG_SYS_GBL_DATA_SIZE 0x100 /* num bytes of initial data */ > +#define CONFIG_SYS_GBL_DATA_OFFSET (CONFIG_SYS_INIT_RAM_END - \ > + CONFIG_SYS_GBL_DATA_SIZE) > +#define CONFIG_SYS_POST_WORD_ADDR (CONFIG_SYS_GBL_DATA_OFFSET - 0x4) > > The CONFIG_SYS_POST_WORD_ADDR is not defined correctly. The base > address is absent. This is true. This macro is slightly confusing and for some other boards it actually means the post word offset. I should have defined _POST_ADDR as (CONFIG_SYS_SRAM_BASE + CONFIG_SYS_POST_WORD_ADDR) in .../mpc5121/common.c file. Since the post test on this board runs quite late (in RAM and not before relocation), this bug didn't show up. Thanks for reporting it! > This will be fixed by POST cleanup consolidated patch anyway. Thanks for this work! Best regards, Anatolij