[U-Boot] [PATCH] bugfix: Guruplug: Use standard miiphy call to reset PHY chip.

[U-Boot] [PATCH] bugfix: Guruplug: Use standard miiphy call to reset PHY chip.

[Mahavir Jain]

From: Mahavir Jain <mjain@marvell.com>

Current PHY Software Reset operation in guruplug does not
poll reset bit in control register to go to 0(auto clearing)
for making sure reset was successful.This patch uses standard
miiphy call miiphy_reset to make sure proper PHY reset operation.

Signed-off-by: Mahavir Jain <mjain@marvell.com>
---
 board/Marvell/guruplug/guruplug.c |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)

diff --git a/board/Marvell/guruplug/guruplug.c b/board/Marvell/guruplug/guruplug.c
index ba47ca1..c028a53 100644
--- a/board/Marvell/guruplug/guruplug.c
+++ b/board/Marvell/guruplug/guruplug.c
@@ -146,14 +146,7 @@ void mv_phy_88e1121_init(char *name)
 	miiphy_write(name, devadr, MV88E1121_PGADR_REG, 0);
 
 	/* reset the phy */
-	if (miiphy_read (name, devadr, PHY_BMCR, &reg) != 0) {
-		printf("Err..(%s) PHY status read failed\n", __FUNCTION__);
-		return;
-	}
-	if (miiphy_write (name, devadr, PHY_BMCR, reg | 0x8000) != 0) {
-		printf("Err..(%s) PHY reset failed\n", __FUNCTION__);
-		return;
-	}
+	miiphy_reset(name, devadr);
 
 	printf("88E1121 Initialized on %s\n", name);
 }
-- 
1.5.4.3

[U-Boot] [PATCH] bugfix: Guruplug: Use standard miiphy call to reset PHY chip.

[Siddarth Gore]

On Tue, 2010-05-18 at 22:20 -0700, Mahavir Jain wrote:
> From: Mahavir Jain <mjain@marvell.com>
> 
> Current PHY Software Reset operation in guruplug does not
> poll reset bit in control register to go to 0(auto clearing)
> for making sure reset was successful.This patch uses standard
> miiphy call miiphy_reset to make sure proper PHY reset operation.
> 

Acked-by: Siddarth Gore <gores@marvell.com>

Same should be done for rd6281a

-siddarth

> Signed-off-by: Mahavir Jain <mjain@marvell.com>
> ---
>  board/Marvell/guruplug/guruplug.c |    9 +--------
>  1 files changed, 1 insertions(+), 8 deletions(-)
> 
> diff --git a/board/Marvell/guruplug/guruplug.c b/board/Marvell/guruplug/guruplug.c
> index ba47ca1..c028a53 100644
> --- a/board/Marvell/guruplug/guruplug.c
> +++ b/board/Marvell/guruplug/guruplug.c
> @@ -146,14 +146,7 @@ void mv_phy_88e1121_init(char *name)
>  	miiphy_write(name, devadr, MV88E1121_PGADR_REG, 0);
>  
>  	/* reset the phy */
> -	if (miiphy_read (name, devadr, PHY_BMCR, &reg) != 0) {
> -		printf("Err..(%s) PHY status read failed\n", __FUNCTION__);
> -		return;
> -	}
> -	if (miiphy_write (name, devadr, PHY_BMCR, reg | 0x8000) != 0) {
> -		printf("Err..(%s) PHY reset failed\n", __FUNCTION__);
> -		return;
> -	}
> +	miiphy_reset(name, devadr);
>  
>  	printf("88E1121 Initialized on %s\n", name);
>  }

[U-Boot] [PATCH] bugfix: Guruplug: Use standard miiphy call to reset PHY chip.

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: Mahavir Jain [mailto:mjain at marvell.com] 
> Sent: Wednesday, May 19, 2010 10:50 AM
> To: Prafulla Wadaskar
> Cc: Prabhanjan Sarnaik; Ashish Karkare; u-boot at lists.denx.de; 
> Mahavir Jain
> Subject: [PATCH] bugfix: Guruplug: Use standard miiphy call 
> to reset PHY chip.
> 
> From: Mahavir Jain <mjain@marvell.com>

Above line is not needed in the description.
Singed-by info indicates the same.
Pls remove it and repost the patch

Regards..
Prafulla . .

[U-Boot] [PATCH] bugfix: Guruplug: Use standard miiphy call to reset PHY chip.

[Peter]

On Wed, 2010-05-19 at 01:38 -0700, Prafulla Wadaskar wrote:
> 
> > -----Original Message-----
> > From: Mahavir Jain [mailto:mjain at marvell.com] 
> > Sent: Wednesday, May 19, 2010 10:50 AM
> > To: Prafulla Wadaskar
> > Cc: Prabhanjan Sarnaik; Ashish Karkare; u-boot at lists.denx.de; 
> > Mahavir Jain
> > Subject: [PATCH] bugfix: Guruplug: Use standard miiphy call 
> > to reset PHY chip.
> > 
> > From: Mahavir Jain <mjain@marvell.com>
> 
> Above line is not needed in the description.
> Singed-by info indicates the same.
> Pls remove it and repost the patch

Hi Prafulla,
'git am' should strip the "From: ..." contents from Mahavir's email.  I
believe by default authorship is given to the email sender, but it can
be overridden by including "From: ..." in the email contents.  So you're
correct that the "From: ..." in Mahavir's email is redundant, but it
also isn't doing any harm so he shouldn't need to resend the patch.
Also, the signed-off-by is not the same as authorship, so he does either
need to send the patch himself, or include the "From: Mahavir..." in the
patch contents.

Best,
Peter

[U-Boot] [PATCH] bugfix: Guruplug: Use standard miiphy call to reset PHY chip.

[Mike Frysinger]

On Wednesday 19 May 2010 04:38:41 Prafulla Wadaskar wrote:
> > -----Original Message-----
> > From: Mahavir Jain [mailto:mjain at marvell.com]
> > Sent: Wednesday, May 19, 2010 10:50 AM
> > To: Prafulla Wadaskar
> > Cc: Prabhanjan Sarnaik; Ashish Karkare; u-boot at lists.denx.de;
> > Mahavir Jain
> > Subject: [PATCH] bugfix: Guruplug: Use standard miiphy call
> > to reset PHY chip.
> > 
> > From: Mahavir Jain <mjain@marvell.com>
> 
> Above line is not needed in the description.
> Singed-by info indicates the same.
> Pls remove it and repost the patch

that isnt necessary as git-am will take care of it.  reading his e-mail source 
indicates that this was added by git-send-email in the first place ...
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20100519/01b52653/attachment.pgp